After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731608 - highlight patch reject files
highlight patch reject files
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
3.10.x
Other Linux
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-13 09:25 UTC by Pierre Ossman
Modified: 2015-06-25 13:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
suggested patch (381 bytes, patch)
2015-06-25 10:00 UTC, Matěj Cepl 		none Details | Review
suggested patch (921 bytes, patch)
2015-06-25 12:38 UTC, Matěj Cepl 		committed Details | Review

Description Pierre Ossman 2014-06-13 09:25:13 UTC 
Reject files from patch (*.rej) would be nice to highlight the same way as other diffs. They have the special type file/x-reject so they should be simple enough to identify.
Comment 1 Sébastien Wilmet 2015-04-13 14:38:13 UTC 
A first step would be to write a .lang file and post it on the wiki:
https://wiki.gnome.org/Projects/GtkSourceView/LanguageDefinitions
Comment 2 Pierre Ossman 2015-04-13 15:34:12 UTC 
It's not a new language. It's the same as any diff. You just need to connect the mime type to the GtkSourceView language.
Comment 3 Sébastien Wilmet 2015-06-25 09:15:11 UTC 
Then adding the mime type and the glob to diff.lang should work fine.
Comment 4 Matěj Cepl 2015-06-25 10:00:52 UTC 
Created attachment 306080 [details] [review]
suggested patch
Comment 5 Sébastien Wilmet 2015-06-25 10:25:22 UTC 
Review of attachment 306080 [details] [review]:

It's better to also add the mime type.

For the patch, it's easier for us if we have a patch created with the 'git format-patch' command, so we have the commit message and author.
Comment 6 Matěj Cepl 2015-06-25 12:38:27 UTC 
Created attachment 306100 [details] [review]
suggested patch

Updated version.

Also available in https://gitlab.com/mcepl/gtksourceview.git as branch rej-diff.