After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731519 - only 1000 transactions imported from CSV file
only 1000 transactions imported from CSV file
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Import - CSV
2.6.3
Other FreeBSD
: Normal normal
: ---
Assigned To: gnucash-import-maint
gnucash-import-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-11 11:54 UTC by Graham Menhennitt
Modified: 2018-06-29 23:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Changes upper limit of spin buttons (1.48 KB, patch)
2014-09-18 15:24 UTC, Bob
none Details | Review
Changes upper limit of end row spin button in the correct order (1.17 KB, patch)
2014-09-19 12:35 UTC, Bob
committed Details | Review

Description Graham Menhennitt 2014-06-11 11:54:10 UTC
If a CSV file of transactions contains more than 1000 lines, only the first 1000 are imported.

Steps to reproduce:
- create CSV file containing more than 1000 transactions
- File -> Import Transactions from CSV
- Select file
- Forward
- Observe that all transactions in file are shown in list box
- Allocate columns
- Forward
- Create new account and select it
- Forward
- Forward
- Observe that only the first 1000 lines are shown in the Match Transactions list
- Apply
- Observe that only the first 1000 transactions have been imported into the new account
Comment 1 Bob 2014-09-18 15:24:03 UTC
Created attachment 286512 [details] [review]
Changes upper limit of spin buttons

This patch changes the upper limit of the row spin buttons from 1000 to 10,000 so it will import max of 10,000 rows.
Comment 2 Graham Menhennitt 2014-09-18 20:47:03 UTC
Thanks for making the change, Bob. But why  is there an upper limit at all? I can't think of a use case where you only want to import the first N records from a file. Why not get rid of the limit entirely?

Graham
Comment 3 Bob 2014-09-19 12:35:52 UTC
Created attachment 286621 [details] [review]
Changes upper limit of end row spin button in the correct order

After another look, I found that the setting of the end row value was before the setting of the upper limit and so was restricted to the value set in the glade file. This fix swaps them around.

Bob
Comment 4 Geert Janssens 2014-09-26 15:21:44 UTC
Comment on attachment 286621 [details] [review]
Changes upper limit of end row spin button in the correct order

Good catch Bob! Thank you for that patch.
Comment 5 John Ralls 2018-06-29 23:31:17 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=731519. Please update any external references or bookmarks.