After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731466 - Adding support of creating detached location and expanding range of cities
Adding support of creating detached location and expanding range of cities
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: locations
unspecified
Other Linux
: Normal normal
: future
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-10 15:42 UTC by Saurabh_P
Modified: 2014-07-01 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (10.25 KB, patch)
2014-06-10 15:54 UTC, Saurabh_P 		none Details | Review
final corrected patch (14.95 KB, patch)
2014-06-16 20:41 UTC, Saurabh_P 		none Details | Review
corrected. (15.83 KB, patch)
2014-06-19 07:49 UTC, Saurabh_P 		committed Details | Review

Description Saurabh_P 2014-06-10 15:42:06 UTC 
I've added support of detached location in location-entry.c. It is working as expected except if I set an internal location as the nearest city then then it works fine but if I add detached location then it gives segfault error after adding few locations.
    I've used the latest patch that I proposed for "no-matches" case. Bug link: https://bugzilla.gnome.org/show_bug.cgi?id=726566
Comment 1 Saurabh_P 2014-06-10 15:54:53 UTC 
Created attachment 278213 [details] [review]
Patch
Comment 2 Saurabh_P 2014-06-16 20:41:59 UTC 
Created attachment 278560 [details] [review]
final corrected patch
Comment 3 Saurabh_P 2014-06-19 07:49:39 UTC 
Created attachment 278735 [details] [review]
corrected.
Comment 4 Giovanni Campagna 2014-07-01 12:57:53 UTC 
Pushed now that the gtk+ patch has landed.