After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731341 - gparam: change value of G_PARAM_EXPLICIT_NOTIFY
gparam: change value of G_PARAM_EXPLICIT_NOTIFY
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-06-06 18:39 UTC by Allison Karlitskaya (desrt)
Modified: 2014-06-10 23:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gparam: change value of G_PARAM_EXPLICIT_NOTIFY (1.59 KB, patch)
2014-06-06 18:40 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2014-06-06 18:39:59 UTC 
GParamSpec has a possibility of user-introduced flags, and we didn't
respect that with the addition of _EXPLICIT_NOTIFY.

Change the documentation for the maximum number of user flags to 10,
just to pick a somewhat random number.  The documentation here was never
correct anyway -- it previously claimed that as many as 38 flags were
possible.

Meanwhile, move G_PARAM_EXPLICIT_NOTIFY next to _DEPRECATED in order to
avoid conflicts with low-numbered user flags (which are in use by at
least evolution-data-server).
Comment 1 Allison Karlitskaya (desrt) 2014-06-06 18:40:01 UTC 
Created attachment 278050 [details] [review]
gparam: change value of G_PARAM_EXPLICIT_NOTIFY
Comment 2 Matthias Clasen 2014-06-10 21:26:08 UTC 
Review of attachment 278050 [details] [review]:

looks good to me.
Comment 3 Michael Natterer 2014-06-10 21:40:20 UTC 
It might be a good idea to reserve some more bits on the upper end
right away?
Comment 4 Michael Natterer 2014-06-10 22:23:02 UTC 
I misread the patch :) never mind...
Comment 5 Allison Karlitskaya (desrt) 2014-06-10 23:05:00 UTC 
Attachment 278050 [details] pushed as fcdd25a - gparam: change value of G_PARAM_EXPLICIT_NOTIFY