After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731337 - Use descriptive labels on board size change dialog
Use descriptive labels on board size change dialog
Status: RESOLVED FIXED
Product: hitori
Classification: Applications
Component: General
0.4.x
Other All
: Normal normal
: ---
Assigned To: hitori-maint
hitori-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-06 16:02 UTC by Michael Catanzaro
Modified: 2014-06-17 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use descriptive labels on board size change dialog (1.08 KB, patch)
2014-06-06 16:02 UTC, Michael Catanzaro 		accepted-commit_now Details | Review
Use descriptive labels on board size change dialog (1.08 KB, patch)
2014-06-17 14:01 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2014-06-06 16:02:55 UTC 
A trivial improvement: when changing the board size while a game is currently in progress, we display a confirmation dialog with Yes/No button labels, which is discouraged by the GNOME HIG.
Comment 1 Michael Catanzaro 2014-06-06 16:02:56 UTC 
Created attachment 278044 [details] [review]
Use descriptive labels on board size change dialog
Comment 2 Philip Withnall 2014-06-11 08:26:01 UTC 
Review of attachment 278044 [details] [review]:

Good catch. ++
Comment 3 Philip Withnall 2014-06-11 08:30:56 UTC 
Review of attachment 278044 [details] [review]:

::: src/main.c
@@ +298,3 @@
+
+		gtk_dialog_add_buttons (GTK_DIALOG (dialog),
+					_("_Keep Playing"), GTK_RESPONSE_REJECT,

As mentioned in bug #731314, I think thisd could be improved to 'Keep _Playing' to make the mnemonics consistent. Please commit with that minor change.
Comment 4 Michael Catanzaro 2014-06-17 14:01:34 UTC 
Created attachment 278602 [details] [review]
Use descriptive labels on board size change dialog
Comment 5 Michael Catanzaro 2014-06-17 14:02:11 UTC 
Attachment 278602 [details] pushed as 8de8b2b - Use descriptive labels on board size change dialog