GNOME Bugzilla – Bug 731309
Fix git ignores
Last modified: 2014-06-23 18:34:31 UTC
Turns out git.mk doesn't really work with nonrecursive Automake, and we're left with several unignored files.
Created attachment 277982 [details] [review] Add src/.gitignore
Review of attachment 277982 [details] [review]: I would much prefer this to be fixed in git.mk if it isn't already. Please try updating git.mk from https://github.com/behdad/git.mk; if that doesn't fix the problem, git.mk needs fixing to be less specific about its .deps and *.o matches.
Fair enough. Looks like this is [1] [1] https://github.com/behdad/git.mk/issues/15
I submitted a patch to git.mk upstream last week but it hasn't gotten any attention yet. Since I think git.mk purity is Not Very Important, would you be OK with applying it in Hitori early?
(In reply to comment #4) > I submitted a patch to git.mk upstream last week but it hasn't gotten any > attention yet. Since I think git.mk purity is Not Very Important, would you be > OK with applying it in Hitori early? By all means! Please include a link to the Github issue in your commit message. We can then refresh git.mk from upstream whenever it’s fixed. Behdad will get round to reviewing it at some point soon, I’m sure. He’s normally pretty quick with these things.
The following fix has been pushed: c23e112 git.mk: ignore .deps and all .o files
Created attachment 279059 [details] [review] git.mk: ignore .deps and all .o files Fixes Untracked files: src/.deps/ src/src_hitori-generator.o src/src_hitori-interface.o src/src_hitori-main.o src/src_hitori-rules.o Proposed for upstream at https://github.com/behdad/git.mk/issues/15