After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731273 - minimise and maximise buttons not present in header bars in gnome classic
minimise and maximise buttons not present in header bars in gnome classic
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
unspecified
Other Linux
: Normal minor
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 730629 730752
Blocks:
 
 
Reported: 2014-06-05 14:39 UTC by Florian Müllner
Modified: 2014-06-06 13:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland: Set gtk-decoration-layout (9.03 KB, patch)
2014-06-05 14:40 UTC, Florian Müllner 		committed Details | Review
wayland: Explicitly handle classic mode for now (3.19 KB, patch)
2014-06-05 14:40 UTC, Florian Müllner 		none Details | Review
wayland: Explicitly handle classic mode for now (3.28 KB, patch)
2014-06-05 15:06 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-06-05 14:39:28 UTC 
+++ This bug was initially created as a clone of Bug #730629 +++

In GNOME 3.12 maximise and minimize buttons can available in the new headers bars that are present in some applications such as Nautilus. They can be turned enabled by setting maximise and minimise to "On" in the "Window" section of the gnome-tweak-tool. 

However, in the GNOME Classic session the maximise and minimise buttons are not present in applications with header bars even though the maximise and minimize options are set to "On" in the gnome-tweak-tool.

Can anyone else confirm this? I'm using GNOME 3.12.2 on Arch Linux 64 bit.
Comment 1 Florian Müllner 2014-06-05 14:40:37 UTC 
Created attachment 277958 [details] [review]
wayland: Set gtk-decoration-layout

Pick up the setting from the org.gnome.desktop.wm.preferences schema
if available. It is slightly more involved than other settings, as
the actual button names used in the schema differ from the ones we
use, so we need an additional translation step.
Comment 2 Florian Müllner 2014-06-05 14:40:43 UTC 
Created attachment 277959 [details] [review]
wayland: Explicitly handle classic mode for now

There are plans to add session-dependent defaults to GSettings
(based on the newly standardized XDG_CURRENT_DESKTOP); until
then, the WM uses a different schema for its button-layout
setting in classic mode. So for the time being, do the same
and pick the alternative schema when XDG_CURRENT_DESKTOP
indicates that we are in a classic session.
(It's not pretty, but hopefully won't be with us for too long ...)
Comment 3 Florian Müllner 2014-06-05 15:06:43 UTC 
Created attachment 277960 [details] [review]
wayland: Explicitly handle classic mode for now

Whoops, didn't test with non-classic - works now ...
Comment 4 Matthias Clasen 2014-06-05 17:12:26 UTC 
Review of attachment 277958 [details] [review]:

Looks ok to me.
Comment 5 Matthias Clasen 2014-06-05 17:12:44 UTC 
Review of attachment 277960 [details] [review]:

ok
Comment 6 Florian Müllner 2014-06-05 17:20:02 UTC 
Thanks for the quick review!

wm-button-layout-translation.[ch] are copy-pasted from the g-s-d patches in bug #730629, so I'll wait for review on those patches as well, to not let those files diverge from the very beginning ...
Comment 7 Florian Müllner 2014-06-06 13:51:21 UTC 
Attachment 277958 [details] pushed as f4c963e - wayland: Set gtk-decoration-layout
Attachment 277960 [details] pushed as add67b5 - wayland: Explicitly handle classic mode for now