After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731271 - replace deprecated gtk_widget_get_state
replace deprecated gtk_widget_get_state
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-05 14:17 UTC by Ondrej Holy
Modified: 2014-06-23 12:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
user-accounts: replace deprecated gtk_widget_get_state (977 bytes, patch)
2014-06-05 14:17 UTC, Ondrej Holy 		needs-work Details | Review
user-accounts: replace deprecated gtk_widget_get_state (1.00 KB, patch)
2014-06-12 11:27 UTC, Ondrej Holy 		needs-work Details | Review
user-accounts: replace deprecated gtk_widget_get_state (1.00 KB, patch)
2014-06-23 11:53 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2014-06-05 14:17:48 UTC 
Created attachment 277956 [details] [review]
user-accounts: replace deprecated gtk_widget_get_state

Replace gtk_widget_get_state by gtk_widget_get_state_flags in um-photo-dialog.c.
Comment 1 Rui Matos 2014-06-06 15:02:16 UTC 
Review of attachment 277956 [details] [review]:

::: panels/user-accounts/um-photo-dialog.c
@@ +531,3 @@
                    UmPhotoDialog  *um)
 {
+        if (gtk_widget_get_state_flags (gtk_bin_get_child (GTK_BIN (widget))) != GTK_STATE_FLAG_PRELIGHT &&

state flags should be compared with & since there might be more than one active
Comment 2 Ondrej Holy 2014-06-12 11:27:06 UTC 
Created attachment 278328 [details] [review]
user-accounts: replace deprecated gtk_widget_get_state

Thanks for review! State flags are now compared with & :-)
Comment 3 Rui Matos 2014-06-12 12:54:52 UTC 
Did you upload the wrong patch? This is still the same as the previous one
Comment 4 Bastien Nocera 2014-06-13 08:09:17 UTC 
Review of attachment 278328 [details] [review]:

Wrong patch indeed.
Comment 5 Ondrej Holy 2014-06-23 11:53:52 UTC 
Created attachment 278994 [details] [review]
user-accounts: replace deprecated gtk_widget_get_state

Sorry for mystification, reupload...
Comment 6 Rui Matos 2014-06-23 12:02:01 UTC 
Review of attachment 278994 [details] [review]:

ok
Comment 7 Ondrej Holy 2014-06-23 12:14:59 UTC 
Comment on attachment 278994 [details] [review]
user-accounts: replace deprecated gtk_widget_get_state

commit 06367651d7bd8432083ec76ccd6182639c70784a