After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731220 - screenshot: Also validate parameters to FlashArea()
screenshot: Also validate parameters to FlashArea()
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-04 15:34 UTC by Florian Müllner
Modified: 2014-06-04 16:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot: Also validate parameters to FlashArea() (2.42 KB, patch)
2014-06-04 15:34 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-06-04 15:34:12 UTC 
Basically a follow-up to bug 694998 and bug 699752, filed upstream as https://bugzilla.redhat.com/show_bug.cgi?id=1104694 (sorry, non-public link).
Comment 1 Florian Müllner 2014-06-04 15:34:16 UTC 
Created attachment 277885 [details] [review]
screenshot: Also validate parameters to FlashArea()

Apply the same parameter validation to FlashArea() we already use
for ScreenshotArea().
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-06-04 15:42:01 UTC 
Review of attachment 277885 [details] [review]:

minor nit

::: js/ui/screenshot.js
@@ +137,3 @@
+            invocation.return_error_literal(Gio.IOErrorEnum,
+                                            Gio.IOErrorEnum.CANCELLED,
+                                            "Invalid params");

Can we use the same formatting on this line for both ScreenshotArea and FlashArea?
Comment 3 Rui Matos 2014-06-04 15:43:23 UTC 
Review of attachment 277885 [details] [review]:

Looks good. Should probably go to older branches as well
Comment 4 Florian Müllner 2014-06-04 16:14:40 UTC 
Attachment 277885 [details] pushed as d98e7db - screenshot: Also validate parameters to FlashArea()