After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731158 - gtkbookmarksmanager.c: save_bookmarks, silly strlen
gtkbookmarksmanager.c: save_bookmarks, silly strlen
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal trivial
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-06-03 12:12 UTC by Morten Welinder
Modified: 2014-06-28 05:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Morten Welinder 2014-06-03 12:12:46 UTC 
The strlen here seems pointless.  Either contents->len is good enough,
or someone forgot to state why it isn't.

  if (!g_file_replace_contents (bookmarks_file,
				contents->str,
				strlen (contents->str),
				NULL, FALSE, 0, NULL,
				NULL, &error))