GNOME Bugzilla – Bug 731127
gnome-weather: add some conditional dependencies
Last modified: 2016-08-23 12:35:30 UTC
I just removed dogtail as a suggests of gnome-weather; maybe this would be a good use for a jhbuild condition? I bet this would be useful for other modules as well. Also, I see gnome-weather supports coverage builds. Might as well hook those up to the existing coverage condition.
Created attachment 277765 [details] [review] gnome-weather: conditionally build with coverage
Created attachment 277766 [details] [review] gnome-weather: conditionally build dogtail tests
Review of attachment 277765 [details] [review]: sure
Ah, I accidentally pushed both of these when you only approved the first one, can you confirm that's OK or should I revert the dogtail patch?
Giovanni is the gnome-weather maintainer, so lets him to decide
Ok with the coverage, because it's default off, but the tests should be default on.
Hi Giovanni, sory, but taking a second look to this, if dogtail depends on pygtk it cant be included in the modulesets by default (pygtk is not part of GNOME for several releases already)
(In reply to comment #7) > Hi Giovanni, > > sory, but taking a second look to this, if dogtail depends on pygtk it cant be > included in the modulesets by default (pygtk is not part of GNOME for several > releases already) Well, dogtail is part of gnome-continuous, and is depended upon by gnome-software too. I understand pygtk is deprecated, but I see no replacement for dogtail anytime soon.
Comment on attachment 277765 [details] [review] gnome-weather: conditionally build with coverage This was pushed a while back
Comment on attachment 277766 [details] [review] gnome-weather: conditionally build dogtail tests This was pushed a while back, but I wonder if it's wrong to provide this even as a conditional, since dogtail only exists in gnome-world.
(In reply to Michael Catanzaro from comment #10) > Comment on attachment 277766 [details] [review] [review] > gnome-weather: conditionally build dogtail tests > > This was pushed a while back, but I wonder if it's wrong to provide this > even as a conditional, since dogtail only exists in gnome-world. Yeah, it's definitely wrong. I'm disabling the tests, sorry. gnome-core cannot depend on anything in gnome-world. I'm concerned that jhbuild did not have a warning about this obvious breakage. :/ That said, it looks like dogtail might not depend on pygtk anymore, so it might be an acceptable dependency for core-deps nowadays. We can investigate that in a separate bug if you want.
Ah, there was no warning because there is a dogtail conditional. It's only conditionally broken. :p
The following fix has been pushed: f1e0296 3.22: gnome-weather has conditional dependency on gnome-world
Created attachment 334004 [details] [review] 3.22: gnome-weather has conditional dependency on gnome-world Remove it.