GNOME Bugzilla – Bug 731119
Add location section to privacy settings
Last modified: 2014-08-19 17:12:29 UTC
There needs to be a way to disable location services, as well as to control which apps can use them. Another important goal for this part of the settings panel is to allow someone to identify which application(s) is currently using location services. "Location" should be added as a section to the list of privacy settings. Designs for the corresponding dialog can be found here: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/privacy/dialogs.png
Maybe the label on the Wi-Fi toggle should be "Wi-Fi Geolocation" to make it clear that it will not turn off your Wi-Fi?
(In reply to comment #1) > Maybe the label on the Wi-Fi toggle should be "Wi-Fi Geolocation" to make it > clear that it will not turn off your Wi-Fi? I'd rather it just wasn't there. I don't think that it's a useful feature to have, and is likely to get too complicated in terms of UI if you take into account USB 3G modems, or USB Wi-Fi.
That makes sense. A typical user probably does not care exactly what technology is being used to find his location, only whether or not an app is using his location in the first place.
(In reply to comment #3) > That makes sense. A typical user probably does not care exactly what technology > is being used to find his location, only whether or not an app is using his > location in the first place. Yeah but I think they do care about what level of accuracy is being accessed. How about controls for accuracy level instead. While we don't need and/or want to have all these in the UI but we have the following range: 1. Country 2. City 3. Neighbourhood 4. Street 5. Exact How about exposing 2, 4 and 5?
(In reply to comment #4) > (In reply to comment #3) > > That makes sense. A typical user probably does not care exactly what technology > > is being used to find his location, only whether or not an app is using his > > location in the first place. > > Yeah but I think they do care about what level of accuracy is being accessed. > How about controls for accuracy level instead. While we don't need and/or want > to have all these in the UI but we have the following range: > > 1. Country > 2. City > 3. Neighbourhood > 4. Street > 5. Exact > > How about exposing 2, 4 and 5? This is pretty much useless. Applications that require exact accuracy won't work well without it (or to a point that makes the application barely any better than a human search). I don't think that showing the accuracy is needed in the interface. It could be made available in Geoclue's D-Bus management interface though (as a debug tool).
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > That makes sense. A typical user probably does not care exactly what technology > > > is being used to find his location, only whether or not an app is using his > > > location in the first place. > > > > Yeah but I think they do care about what level of accuracy is being accessed. > > How about controls for accuracy level instead. While we don't need and/or want > > to have all these in the UI but we have the following range: > > > > 1. Country > > 2. City > > 3. Neighbourhood > > 4. Street > > 5. Exact > > > > How about exposing 2, 4 and 5? > > This is pretty much useless. Applications that require exact accuracy won't > work well without it (or to a point that makes the application barely any > better than a human search). I don't think that showing the accuracy is needed > in the interface. It could be made available in Geoclue's D-Bus management > interface though (as a debug tool). Hmm.. so how does privacy panel would look like then? Just a dialog with description and a simple switch?
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > Yeah but I think they do care about what level of accuracy is being accessed. > > How about controls for accuracy level instead. While we don't need and/or want > > to have all these in the UI but we have the following range: > > > > 1. Country > > 2. City > > 3. Neighbourhood > > 4. Street > > 5. Exact > > > > How about exposing 2, 4 and 5? > > This is pretty much useless. Applications that require exact accuracy won't > work well without it (or to a point that makes the application barely any > better than a human search). If user is not confortable with any application accessing exact location, that should be an acceptable compromise to them.
(In reply to comment #6) > Hmm.. so how does privacy panel would look like then? Just a dialog with > description and a simple switch? Right now, it would probably just be a single switch until we can get per-application settings (that means having the agent enabled by default in gnome-shell). FWIW, I'd rather have something that's complete, but circumventable (this is the case for Notifications as well), rather than just a single switch. Jasper disagrees though. (In reply to comment #7) > If user is not confortable with any application accessing exact location, that > should be an acceptable compromise to them. If the user isn't comfortable with sharing their locations, they would probably disable it altogether, or on a per application basis.
(In reply to comment #8) > (In reply to comment #6) > > Hmm.. so how does privacy panel would look like then? Just a dialog with > > description and a simple switch? > > Right now, it would probably just be a single switch until we can get > per-application settings (that means having the agent enabled by default in > gnome-shell). > > FWIW, I'd rather have something that's complete, but circumventable (this is > the case for Notifications as well), rather than just a single switch. Jasper > disagrees though. Yeah and we failed to convince him otherwise after long discussions. :( Having said that, if I understood correctly he was more against the dialog and not against having per-app setting in privacy panel. Besides he is not the maintainer of control-center so we don't necessarily need to convince him for this, do we? :P > (In reply to comment #7) > > If user is not confortable with any application accessing exact location, that > > should be an acceptable compromise to them. > > If the user isn't comfortable with sharing their locations, Its not a black&white thing. If user is comfortable sharing their current city info with a random app, doesn't mean they are confortable sharing their exact location as well.
(In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #6) > > > Hmm.. so how does privacy panel would look like then? Just a dialog with > > > description and a simple switch? > > > > Right now, it would probably just be a single switch until we can get > > per-application settings (that means having the agent enabled by default in > > gnome-shell). > > > > FWIW, I'd rather have something that's complete, but circumventable (this is > > the case for Notifications as well), rather than just a single switch. Jasper > > disagrees though. > > Yeah and we failed to convince him otherwise after long discussions. :( Having > said that, if I understood correctly he was more against the dialog and not > against having per-app setting in privacy panel. Besides he is not the > maintainer of control-center so we don't necessarily need to convince him for > this, do we? :P If we have information about per-application settings available, I'm happy to go with that, but I'm wary of the fact that we won't get a popup asking us if Maps wants to have access to Geolocation, we'd only be able to stop it after it's accessing location at least once. Which is a problem. > > (In reply to comment #7) > > > If user is not confortable with any application accessing exact location, that > > > should be an acceptable compromise to them. > > > > If the user isn't comfortable with sharing their locations, > > Its not a black&white thing. If user is comfortable sharing their current city > info with a random app, doesn't mean they are confortable sharing their exact > location as well. I don't see what there would be to gain compare to having the user input the address they want to use as their current location. If I was standing in the town hall, the "city" accuracy would actually say where I am as well. There are no other OSes offering this level of configuration either.
Created attachment 282916 [details] [review] privacy: Add location setting For now its just a switch to enable/disable geolocation through gnome-shell's setting. In future we'll hopefully at least have controls to enable/disable geolocation for applications from here.
(In reply to comment #11) > Created an attachment (id=282916) [details] [review] > privacy: Add location setting This requires my patches to gnome-shell in bug#734483.
Review of attachment 282916 [details] [review]: Until we have per-app controls, and given that it's a single switch, the switch should be directly on the main page, not on its own in a dialogue. Go to "Settings" -> "Power" -> "Power Saving" section and look at the "Wi-Fi" entry. It has a single switch, and description text. The "Locations Services" item should be like this one.
(In reply to comment #13) > Review of attachment 282916 [details] [review]: > > Until we have per-app controls, and given that it's a single switch, the switch > should be directly on the main page, not on its own in a dialogue. > > Go to "Settings" -> "Power" -> "Power Saving" section and look at the "Wi-Fi" > entry. It has a single switch, and description text. The "Locations Services" > item should be like this one. Well thats what I was asking about in comment#6. :)
(In reply to comment #14) > (In reply to comment #13) > > Review of attachment 282916 [details] [review] [details]: > > > > Until we have per-app controls, and given that it's a single switch, the switch > > should be directly on the main page, not on its own in a dialogue. > > > > Go to "Settings" -> "Power" -> "Power Saving" section and look at the "Wi-Fi" > > entry. It has a single switch, and description text. The "Locations Services" > > item should be like this one. That entry is not alone on that panel. All options there are directly available for tweaking. I think it would look odd in privacy panel to have everything else behind a dialog and just one of the options avaliable directly. Allan?
Created attachment 283010 [details] [review] privacy: Add location setting Same as last patch, except schema location has been updated as per bug#734555.
(In reply to comment #15) > (In reply to comment #14) > > (In reply to comment #13) > > > Review of attachment 282916 [details] [review] [details] [details]: > > > > > > Until we have per-app controls, and given that it's a single switch, the switch > > > should be directly on the main page, not on its own in a dialogue. > > > > > > Go to "Settings" -> "Power" -> "Power Saving" section and look at the "Wi-Fi" > > > entry. It has a single switch, and description text. The "Locations Services" > > > item should be like this one. > > That entry is not alone on that panel. All options there are directly available > for tweaking. I think it would look odd in privacy panel to have everything > else behind a dialog and just one of the options avaliable directly. Allan? It's alone in the dialogue. You have nothing else but a switch in the dialogue, so no need to use a dialogue. When we have more things to show, we'll move it to a dialogue.
(In reply to comment #17) > (In reply to comment #15) > > (In reply to comment #14) > > > (In reply to comment #13) > > > > Review of attachment 282916 [details] [review] [details] [details] [details]: > > > > > > > > Until we have per-app controls, and given that it's a single switch, the switch > > > > should be directly on the main page, not on its own in a dialogue. > > > > > > > > Go to "Settings" -> "Power" -> "Power Saving" section and look at the "Wi-Fi" > > > > entry. It has a single switch, and description text. The "Locations Services" > > > > item should be like this one. > > > > That entry is not alone on that panel. All options there are directly available > > for tweaking. I think it would look odd in privacy panel to have everything > > else behind a dialog and just one of the options avaliable directly. Allan? > > It's alone in the dialogue. You have nothing else but a switch in the dialogue, > so no need to use a dialogue. When we have more things to show, we'll move it > to a dialogue. I understand what you are saying but I think you misunderstood me. I'm saying that this option looking different from all the other settings will look odd in the privacy panel.
Created attachment 283607 [details] [review] privacy: Add location setting Merged the dialog contents to privacy panel.
Review of attachment 283607 [details] [review]: You'll also need to bump gsettings-desktop-schemas version in configure.ac ::: panels/privacy/privacy.ui @@ +743,3 @@ + <property name="margin_bottom">6</property> + <property name="xalign">0</property> + <property name="label" translatable="yes">Location services allow applications to determine your geographical position.</property> No, this needs to be shorter, be inside the GtkListBoxRow itself (dimmed, as in the example in the Power panel), and I don't think this is very useful a description.
Review of attachment 283607 [details] [review]: ::: panels/privacy/privacy.ui @@ +743,3 @@ + <property name="margin_bottom">6</property> + <property name="xalign">0</property> + <property name="label" translatable="yes">Location services allow applications to determine your geographical position.</property> As a native English speaker, what do you suggest? :) I just copy&pasted from Allan's mockup.
Created attachment 283803 [details] Screenshot w/ extra label
Created attachment 283804 [details] Screenshot w/o extra label
Which one you prefer? I didn't find any example of where to place the description label from power panel.
If we add a label, it needs to be underneath the switch label, like the label under the Wi-Fi switch in the Power panel. "Used to determine your geographical location" is shorter, and we don't need the subject (it's just above).
Created attachment 283810 [details] [review] configure: Require gsettings-desktop-schemas >= 3.13.90 This is required for new location panel.
Created attachment 283811 [details] [review] privacy: Add location setting Move outside label into the grid as a short hint.
> "Used to determine your geographical location" is shorter, and we don't need > the subject (it's just above). "Allows applications to determine your geographical location" -- otherwise I would assume that only the operating system will be able to use it.
Created attachment 283840 [details] [review] privacy: Add location setting Act on Michael's advice in comment#28.
Would be nice to get this in before 3.13.90 and feature/UI freeze.
(In reply to comment #28) > > "Used to determine your geographical location" is shorter, and we don't need > > the subject (it's just above). > > "Allows applications to determine your geographical location" -- otherwise I > would assume that only the operating system will be able to use it. That's too long to fit in the panel without resizing it. Longer term, we should have a link at the bottom of the page to an online resource explaining which services we're using, and the ToS for the various services.
I repurposed the first patch to update the requirements for the search panel as well. For the second patch, I changed the label back to my original idea. Michael, feel free to file a new bug about that label and CC: Allan for advice, the label needs to be short enough that the window doesn't resize in width between the main view and the panel. Attachment 283840 [details] pushed as 7bcf4c1 - privacy: Add location setting