After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731075 - The Puzzles is wrong in RTL
The Puzzles is wrong in RTL
Status: RESOLVED FIXED
Product: gnome-sudoku
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-sudoku-maint
gnome-sudoku-maint
Depends on:
Blocks:
 
 
Reported: 2014-06-01 11:32 UTC by Yosef Or Boczko
Modified: 2014-06-01 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot in Hebrew (RTL language) (110.36 KB, image/png)
2014-06-01 11:32 UTC, Yosef Or Boczko 		  Details
SudokuView: Make it works correct in RTL (831 bytes, patch)
2014-06-01 11:42 UTC, Yosef Or Boczko 		none Details | Review
SudokuView: Make it works correct in RTL (1.13 KB, patch)
2014-06-01 12:36 UTC, Yosef Or Boczko 		committed Details | Review

Description Yosef Or Boczko 2014-06-01 11:32:22 UTC 
Created attachment 277671 [details]
Screenshot in Hebrew (RTL language)

See the screenshot.
Comment 1 Yosef Or Boczko 2014-06-01 11:42:03 UTC 
Created attachment 277673 [details] [review]
SudokuView: Make it works correct in RTL
Comment 2 Yosef Or Boczko 2014-06-01 11:43:30 UTC 
And now we needs to be worried - why it doesn't work correctly in RTL?
GtkGrid support RTL, as far I know.
Comment 3 Parin Porecha 2014-06-01 11:57:47 UTC 
Looking at the screenshot, block separator lines are drawn between wrong columns in RTL.
This is due to https://git.gnome.org/browse/gnome-sudoku/tree/src/sudoku-view.vala#n565 (lines 565 - 568).
GtkGrid isn't the problem here.

Are there any other bugs in RTL apart from this ?
Comment 4 Yosef Or Boczko 2014-06-01 11:59:50 UTC 
(In reply to comment #3)
> Are there any other bugs in RTL apart from this ?

Yes, the margin around the buttons numbers in the side (the 3 * 3 lines
of buttons of the numbers 1 - 9).
See the margin there in RTL and in LTR.
Comment 5 Parin Porecha 2014-06-01 12:22:13 UTC 
(In reply to comment #4)
> Yes, the margin around the buttons numbers in the side (the 3 * 3 lines
> of buttons of the numbers 1 - 9).
> See the margin there in RTL and in LTR.

The number picker is going to be removed soon.
New Game and Restart buttons will take its place. I'll make sure their margins are correct.
Comment 6 Yosef Or Boczko 2014-06-01 12:36:09 UTC 
Created attachment 277677 [details] [review]
SudokuView: Make it works correct in RTL
Comment 7 Michael Catanzaro 2014-06-01 17:06:17 UTC 
Review of attachment 277677 [details] [review]:

Thanks
Comment 8 Yosef Or Boczko 2014-06-01 17:08:06 UTC 
Review of attachment 277677 [details] [review]:

Pushed as 3a0a84c - SudokuView: Make it works correct in RTL