After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730961 - Use %NULL, %TRUE, and %FALSE instead of NULL, TRUE, and FALSE
Use %NULL, %TRUE, and %FALSE instead of NULL, TRUE, and FALSE
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: documentation
unspecified
Other Linux
: Normal normal
: 1.3.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-29 22:00 UTC by Evan Nemerson
Modified: 2014-05-29 23:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
docs: convert NULL, TRUE, and FALSE to %NULL, %TRUE, and %FALSE (212.61 KB, patch)
2014-05-29 22:00 UTC, Evan Nemerson
needs-work Details | Review
docs: convert NULL, TRUE, and FALSE to %NULL, %TRUE, and %FALSE (207.89 KB, patch)
2014-05-29 23:00 UTC, Evan Nemerson
committed Details | Review

Description Evan Nemerson 2014-05-29 22:00:21 UTC
Created attachment 277494 [details] [review]
docs: convert NULL, TRUE, and FALSE to %NULL, %TRUE, and %FALSE

This should help improve documentation generated for languages other than C.
Comment 1 Tim-Philipp Müller 2014-05-29 22:23:11 UTC
Comment on attachment 277494 [details] [review]
docs: convert NULL, TRUE, and FALSE to %NULL, %TRUE, and %FALSE

Sometimes NULL is being used as abbreviation for GST_STATE_NULL, in those cases it should not be replaced with %NULL.
Comment 2 Nicolas Dufresne (ndufresne) 2014-05-29 23:00:18 UTC
Replacing is by %GST_STATE_NULL is also an option. It will endup being a link, and will be mangled for different languages.
Comment 3 Evan Nemerson 2014-05-29 23:00:39 UTC
Created attachment 277500 [details] [review]
docs: convert NULL, TRUE, and FALSE to %NULL, %TRUE, and %FALSE

Those should really probably change to %GST_STATE_NULL, but that can be done in another patch.
Comment 4 Tim-Philipp Müller 2014-05-29 23:28:28 UTC
Pushed, thanks:

commit e10266e3f3cf9b05b69198b1ac6faa9a62840e30
Author: Evan Nemerson <evan@nemerson.com>
Date:   Thu May 29 14:54:34 2014 -0700

    docs: convert NULL, TRUE, and FALSE to %NULL, %TRUE, and %FALSE
    
    This should help improve documentation generated for
    languages other than C.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730961