After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730887 - [PATCH] Fix potential copy and paste error in inputstring.cpp
[PATCH] Fix potential copy and paste error in inputstring.cpp
Status: RESOLVED FIXED
Product: doxygen
Classification: Other
Component: general
1.8.7-GIT
Other Linux
: Normal normal
: ---
Assigned To: Dimitri van Heesch
Dimitri van Heesch
Depends on:
Blocks:
 
 
Reported: 2014-05-28 12:57 UTC by Ettl Martin
Modified: 2014-08-21 17:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (498 bytes, patch)
2014-05-28 12:57 UTC, Ettl Martin 		none Details | Review

Description Ettl Martin 2014-05-28 12:57:18 UTC 
Created attachment 277386 [details] [review]
proposed fix

Please review the attached patch. It fixes a potential copy and paste error in  inputstring.cpp.

Best regards and many thanks

Martin Ettl
Comment 1 albert 2014-05-29 07:59:17 UTC 
I think the proposed change in the patch should be applied, currently only PROJECT_LOGO uses this feature. The PROJECT_LOGO is always visible so the setEnabled is always TRUE, but in future there might be settings that can be disabled and than this problem would occur.


@Martin how did you find this problem, did you use any tools for it?
Comment 2 Ettl Martin 2014-05-30 07:10:15 UTC 
Hi,
i habe found this issue during a code review. Do you know any tool that finds those kind of issues?

Best regards

Martin
Comment 3 Dimitri van Heesch 2014-06-07 22:35:36 UTC 
Thanks, I'll include the patch in the next GIT update.
Comment 4 Dimitri van Heesch 2014-08-21 17:15:13 UTC 
This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.8. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information 
that you think can be relevant (preferrably in the form of a self-contained example).