After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730865 - x264enc: fix caps leak in set_format()
x264enc: fix caps leak in set_format()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal minor
: 1.3.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-28 07:58 UTC by Aurélien Zanelli
Modified: 2014-05-28 08:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
x264enc: fix caps leak in set_format() (687 bytes, patch)
2014-05-28 07:58 UTC, Aurélien Zanelli 		committed Details | Review

Description Aurélien Zanelli 2014-05-28 07:58:12 UTC 
Created attachment 277359 [details] [review]
x264enc: fix caps leak in set_format()

When allowed caps is empty, the set_format() function returns without unrefing the template caps got by gst_static_pad_template_get_caps()

I attached a patch which fix the leak
Comment 1 Sebastian Dröge (slomo) 2014-05-28 08:10:02 UTC 
commit 84b20091550641157fdf899268ab6da74f6fe3cd
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Wed May 28 09:49:59 2014 +0200

    x264enc: fix caps leak in set_format()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730865