After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730854 - example: ts-parser: add component, content, stream id, ca id, parential rating descriptors
example: ts-parser: add component, content, stream id, ca id, parential ratin...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.3.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-27 20:29 UTC by Stefan Ringel
Modified: 2014-05-29 12:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add component descriptor (2.12 KB, patch)
2014-05-27 20:29 UTC, Stefan Ringel 		none Details | Review
add content descriptor (1.69 KB, patch)
2014-05-27 20:30 UTC, Stefan Ringel 		none Details | Review
add stream identifier descriptor (1.04 KB, patch)
2014-05-27 20:30 UTC, Stefan Ringel 		none Details | Review
add ca identifier descriptor (1.15 KB, patch)
2014-05-27 20:31 UTC, Stefan Ringel 		none Details | Review
add parential rating descriptor (1.94 KB, patch)
2014-05-27 20:31 UTC, Stefan Ringel 		none Details | Review
add component descriptor (3.72 KB, patch)
2014-05-28 10:26 UTC, Stefan Ringel 		committed Details | Review
add content descriptor (3.37 KB, patch)
2014-05-28 10:26 UTC, Stefan Ringel 		committed Details | Review
add stream identifier descriptor (1.04 KB, patch)
2014-05-28 10:26 UTC, Stefan Ringel 		committed Details | Review
add ca identifier descriptor (1.15 KB, patch)
2014-05-28 10:27 UTC, Stefan Ringel 		none Details | Review
add parental rating descriptor (1.94 KB, patch)
2014-05-28 10:28 UTC, Stefan Ringel 		none Details | Review
add dvb ca indentifier descriptor (1.15 KB, patch)
2014-05-28 14:50 UTC, Stefan Ringel 		committed Details | Review
add parential rating descriptor (1.94 KB, patch)
2014-05-28 14:50 UTC, Stefan Ringel 		committed Details | Review

Description Stefan Ringel 2014-05-27 20:29:36 UTC 
Created attachment 277338 [details] [review]
add component descriptor

example: ts-parser: add component, content, stream id, ca id, parential rating descriptors
Comment 1 Stefan Ringel 2014-05-27 20:30:09 UTC 
Created attachment 277339 [details] [review]
add content descriptor
Comment 2 Stefan Ringel 2014-05-27 20:30:42 UTC 
Created attachment 277340 [details] [review]
add stream identifier descriptor
Comment 3 Stefan Ringel 2014-05-27 20:31:10 UTC 
Created attachment 277341 [details] [review]
add ca identifier descriptor
Comment 4 Stefan Ringel 2014-05-27 20:31:46 UTC 
Created attachment 277342 [details] [review]
add parential rating descriptor
Comment 5 Edward Hervey 2014-05-28 05:27:33 UTC 
Yay \o/

Some notes:
* use "component tag" where appropriate (instead of Descriptor tag)
* Any chance we could have an enum for the various content/component types ? At least for the high-nibble ?
Comment 6 Edward Hervey 2014-05-28 05:47:48 UTC 
Also, the various text fields (like in the component descriptor) should be properly initialized to NULL, otherwise you end up with garbage data
Comment 7 Stefan Ringel 2014-05-28 06:42:55 UTC 
(In reply to comment #5)
> Yay \o/
> 
> Some notes:
> * use "component tag" where appropriate (instead of Descriptor tag)
> * Any chance we could have an enum for the various content/component types ? At
> least for the high-nibble ?

o.k. for content -> different between dvb and isdb.
Comment 8 Stefan Ringel 2014-05-28 08:59:32 UTC 
(In reply to comment #5)
> * Any chance we could have an enum for the various content/component types ? At
> least for the high-nibble ?

is it better to mapping it (in parsing method) to metadata tags or to one enum for all contents + one for all components (DVB, ISDB, ATSC etc.)?
Comment 9 Stefan Ringel 2014-05-28 10:26:02 UTC 
Created attachment 277377 [details] [review]
add component descriptor
Comment 10 Stefan Ringel 2014-05-28 10:26:26 UTC 
Created attachment 277378 [details] [review]
add content descriptor
Comment 11 Stefan Ringel 2014-05-28 10:26:53 UTC 
Created attachment 277379 [details] [review]
add stream identifier descriptor
Comment 12 Stefan Ringel 2014-05-28 10:27:33 UTC 
Created attachment 277380 [details] [review]
add ca identifier descriptor
Comment 13 Stefan Ringel 2014-05-28 10:28:01 UTC 
Created attachment 277381 [details] [review]
add parental rating descriptor
Comment 14 Edward Hervey 2014-05-28 13:33:10 UTC 
You are re-using the i variable for some loops (ex: ca descriptor) ...
.. that i variable is already used for the top-level loop variable

Either use a different variable name or move to separate functions
Comment 15 Stefan Ringel 2014-05-28 14:50:02 UTC 
Created attachment 277392 [details] [review]
add dvb ca indentifier descriptor
Comment 16 Stefan Ringel 2014-05-28 14:50:28 UTC 
Created attachment 277393 [details] [review]
add parential rating descriptor
Comment 17 Edward Hervey 2014-05-29 12:30:19 UTC 
commited.