After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730691 - Fix invalid GEnumValue.value_name entries
Fix invalid GEnumValue.value_name entries
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-editing-services
git master
Other Linux
: Normal normal
: 1.3.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-24 17:23 UTC by Christoph Reiter (lazka)
Modified: 2014-09-23 09:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (23.60 KB, patch)
2014-05-24 17:23 UTC, Christoph Reiter (lazka) 		committed Details | Review

Description Christoph Reiter (lazka) 2014-05-24 17:23:16 UTC 
Created attachment 277121 [details] [review]
patch

From 96a95aed7cbedd678fc40ae7965bb7a370e11eea Mon Sep 17 00:00:00 2001
From: Christoph Reiter <reiter.christoph@gmail.com>
Date: Sat, 24 May 2014 19:16:12 +0200
Subject: [PATCH] Fix invalid GEnumValue.value_name entries.

This makes the enum entries in the gir have valid c:identifiers and documentation.
Comment 1 Thibault Saunier 2014-05-24 18:04:24 UTC 
I agree this is an abuse of the value_name field but it was pretty useful to be able to proide a documentation to be used at runtime. In pitivi for example we do expose that directly in the UI I believe so it would be kind of an API breakage to change that. I am not sure how we should move forward, do you have any idea?
Comment 2 Christoph Reiter (lazka) 2014-05-24 18:14:09 UTC 
No idea. I see that pitivi has translations, so maybe it makes sense to move the enum -> description mapping to pitivi anyway.