GNOME Bugzilla – Bug 730642
mpegts: atsc: rename TVCT to VCT as it is the same as CVCT
Last modified: 2014-05-29 08:46:17 UTC
Before releasing the next stable version (1.4) we should rename the TVCT code to be simply VCT to be able to use the same struct/functions for both TVCT and CVCT that have the same fields (except for 2 reserved bits being used by one of them).
Created attachment 277073 [details] [review] mpegts: atsc: rename TVCT to VCT as it is the same as CVCT Make the ATSC section parse handle both TVCT and CVCT as they are nearly the same struct (CVCT uses 2 reserved bits that are ignored in TVCT). This is changing the glib type and the struct name but TVCT wasn't released in a stable package yet so there should be no problem.
Thanks for that. Any chance you could also include a patch for the ts-parser example to validate this ?
Created attachment 277400 [details] [review] examples: ts-parser: add TVCT and CVCT tables dumping
Created attachment 277401 [details] [review] mpegts: add atsc MGT section parsing Add a parsing function for MGT and also detect the EIT tables for ATSC, the EIT pids are reported inside the MGT and we are still only relying only on the table id for detecting it. In the future we would want to also check the pid and compare with whatever the MGT previously reported to confirm that it is indeed the EIT. https://bugzilla.gnome.org/show_bug.cgi?id=730435
Comment on attachment 277401 [details] [review] mpegts: add atsc MGT section parsing Oops, wrong patch
Created attachment 277403 [details] [review] mpegts: atsc: rename TVCT to VCT as it is the same as CVCT Updated patch with some fixes: * parsing fixes * utf16 -> utf8 conversion for channel short name I only got streams with TVCT to test here, but the code should be mostly the same for both
Created attachment 277409 [details] [review] mpegts: atsc: rename TVCT to VCT as it is the same as CVCT Added minor fix for when the string is empty
Pushed, thanks.