After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730570 - dvbsrc: fix building with newer kernel headers
dvbsrc: fix building with newer kernel headers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.3.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-22 10:30 UTC by Michael Olbrich
Modified: 2014-05-22 11:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.61 KB, patch)
2014-05-22 10:30 UTC, Michael Olbrich 		committed Details | Review

Description Michael Olbrich 2014-05-22 10:30:10 UTC 
Created attachment 276975 [details] [review]
patch

c400eef3772b7dc470eefae02a1288c2b125e25c introduced some defines to handle
older kernel headers. However, the check is done before the corresponding
kernel header (dvb/frontend.h) is included. As a result the macros are
always defined with results in 'redefined' errors with newer kernel
headers.
Move the check after the include to fix this.

Note: this is only compile-time tested.
Comment 1 Edward Hervey 2014-05-22 11:03:10 UTC 
whoops, nice catch :)

commit c1db46ffc61edd3489667012e354f5ed106a2d43
Author: Michael Olbrich <m.olbrich@pengutronix.de>
Date:   Thu May 22 12:23:57 2014 +0200

    dvbsrc: fix building with newer kernel headers
    
    c400eef3772b7dc470eefae02a1288c2b125e25c introduced some defines to handle
    older kernel headers. However, the check is done before the corresponding
    kernel header (dvb/frontend.h) is included. As a result the macros are
    always defined with results in 'redefined' errors with newer kernel
    headers.
    Move the check after the include to fix this.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=730570