After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730493 - Port annotations from Vala metadata
Port annotations from Vala metadata
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
: 728327 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-05-21 07:36 UTC by Evan Nemerson
Modified: 2017-03-09 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gio: port annotations from the Vala metadata. (18.84 KB, patch)
2014-05-21 07:36 UTC, Evan Nemerson 		committed Details | Review

Description Evan Nemerson 2014-05-21 07:36:39 UTC 
Created attachment 276916 [details] [review]
gio: port annotations from the Vala metadata.

I just went through the Vala's metadata and converted what I could to G-I annotations.  Patch attached.
Comment 1 Colin Walters 2014-05-23 16:44:38 UTC 
Review of attachment 276916 [details] [review]:

Looks OK, just one minor comment which doesn't have to be changed.

::: gio/gpollableinputstream.c
@@ +160,3 @@
  * g_pollable_input_stream_read_nonblocking:
  * @stream: a #GPollableInputStream
+ * @buffer: (array length=count) (element-type guint8): a buffer to

This one in the future I would prefer as a separate patch, since it's distinct from nullable/optional.
Comment 2 Philip Withnall 2017-03-09 14:06:23 UTC 
*** Bug 728327 has been marked as a duplicate of this bug. ***