GNOME Bugzilla – Bug 730349
gst-omx aac encoder on msm89x6
Last modified: 2018-05-05 16:11:43 UTC
I just found that slomo recently updated gst-omx and I couldn't see yet if the patch is to solve issues that I was able to workaround by my patch that I'm posting now. However, this is true that aacencoder didn't work as itself at least the moment that I made this patch. My device is qcom msm89x6 and the below is what my patch tries to fix: 1. qcom chipset needs not to disable any ports in gst_omx_audio_enc_set_format() -> this is what slomo noticed me a long time ago and probably what he just updated. 2. gstomxaacenc.c doesn't seem to work with the general gstreamer negotiation routine. -> this encoder tries to use undefined caps yet by negotiation feature and dies making severe error. (not-negotiated...) so I had to put some workaround to gstomxaacenc.c This is my first time to upload to bugzilla so please inform me if I missed something.
Created attachment 276738 [details] [review] to enable aacencoder on qcom msm89x6
still the omxaacenc may have a wrong sinkcap but the encoding feature should be enabled by this patch. e.g) wav -> aac gst-launch-1.0 filesrc location=[.wav] ! wa vparse ! omxaacenc ! 3gppmux ! filesink location=output.aac
Can you attach a new patch that applies cleanly against latest GIT master? Yours contains some rather weird looking changes in there right now. For that just clone the gst-omx GIT repository, apply your changes and commit the locally. Then you can extract them into patches with "git format-patch", and attach them here. 1) is fixed now btw, if you set hacks=no-disable-outport in your gstomx.conf 2) I don't really understand, what exactly is the problem there?
Also thanks for your patch :) And I forgot to mention that it's usually easier to review patches if you have one functional change per patch, and not multiple orthogonal changes in the same patch
For the second one, I'll reproduce the issue and post more detailed information with the log message. OK, one functional change per patch. :)
I confirmed that this patch works for gstreamer 1.2 + -base 1.2 + gst-omx (based on 1.2) on msm89x26.
slomo, may I break the patch into each one for each file?
Not necessarily, but break it into one functional change per patch instead of having lots of unrelated changes in a single patch
Closing this bug report as no further information has been provided. Please feel free to reopen this bug report if you can provide the information that was asked for in a previous comment. Thanks!