After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 730232 - print dialog clips off left page size label on A4 landscape mode
print dialog clips off left page size label on A4 landscape mode
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Printing
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-05-16 07:06 UTC by Tuomas Kuosmanen
Modified: 2014-12-01 12:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
example of clipped font (247.37 KB, image/png)
2014-05-16 07:06 UTC, Tuomas Kuosmanen
  Details
Don't crop dimensions of layout preview (1.69 KB, patch)
2014-11-28 14:29 UTC, Marek Kašík
committed Details | Review

Description Tuomas Kuosmanen 2014-05-16 07:06:23 UTC
Created attachment 276653 [details]
example of clipped font

This is Shotwell, but I guess it's the stock gtk print dialog, thus filed in gtk.

Prerequisities: 
  Interface font set to "Cantarell Medium 11" in tweak tool 
  (I think this is the default, but I am not 100% sure)

How to reproduce:
  1. Open photo in Shotwell
  2. Select File → Print...
  3. Select "Page Setup" -tab
  4. Set page to A4 with landscape orientation

Observe the preview of image view (the width / height labels). The height label gets clipped on left side (see attachment).

(Gtk version: gtk3-3.12.1-1.fc20.x86_64)
Comment 1 Tuomas Kuosmanen 2014-05-16 07:08:33 UTC
Actually, it appears the font on the preview labels does not follow system interface font settings.

By visual comparison, it looks like it's using the default "Sans" font (fallback?) with the size setting (11) from system font. Cantarell is visually a bit smaller and wider.

Maybe the widget sizing assumes system font metrics, but it just uses "Sans" and this does not match?
Comment 2 Marek Kašík 2014-11-28 14:29:46 UTC
Created attachment 291723 [details] [review]
Don't crop dimensions of layout preview

Hi,

thank you for this report.
Attached patch increases the basic dimensions of the GtkDrawingArea used for drawing of the layout preview + it sets "fill" property of the drawing area to True.

Marek
Comment 3 Matthias Clasen 2014-11-29 03:17:14 UTC
Review of attachment 291723 [details] [review]:

sure, looks fine, if it works
Comment 4 Marek Kašík 2014-12-01 12:15:00 UTC
Comment on attachment 291723 [details] [review]
Don't crop dimensions of layout preview

(In reply to comment #3)
> Review of attachment 291723 [details] [review]:
> 
> sure, looks fine, if it works

Thank you for the review. I've pushed the patch to master and 3-14 branch.