Bug 730142 – placessidebar: use proper canonicalization when checking if home

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 730142 - placessidebar: use proper canonicalization when checking if home


Summary:	placessidebar: use proper canonicalization when checking if home


Status:	RESOLVED FIXED

Product:	gtk+
Classification:	Platform
Component:	.General
Version:	unspecified
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	gtk-bugs
QA Contact:	gtk-bugs

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2014-05-14 18:34 UTC by Cosimo Cecchi
Modified:	2014-05-14 23:07 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
placessidebar: use proper canonicalization when checking if home (1.97 KB, patch) 2014-05-14 18:35 UTC, Cosimo Cecchi	committed	Details \| Review

Description Cosimo Cecchi 2014-05-14 18:34:48 UTC

See attached patch

Comment 1 Cosimo Cecchi 2014-05-14 18:35:21 UTC

Created attachment 276553 [details] [review]
placessidebar: use proper canonicalization when checking if home

Instead of just checking the string. This catches things like double
slashes, relative paths and so on.

Comment 2 Matthias Clasen 2014-05-14 22:50:09 UTC

Review of attachment 276553 [details] [review]:

ok

Comment 3 Cosimo Cecchi 2014-05-14 23:07:47 UTC

Thanks, pushed to master.