After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729884 - Unbreak vte-2.91 -T
Unbreak vte-2.91 -T
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.37.x
Other All
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
: 728675 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-05-09 16:30 UTC by Debarshi Ray
Modified: 2014-05-12 09:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
widget: Set the background alpha in set_colors (961 bytes, patch)
2014-05-09 16:34 UTC, Debarshi Ray 		none Details | Review
widget: Set the background alpha in set_colors (980 bytes, patch)
2014-05-09 16:44 UTC, Debarshi Ray 		committed Details | Review
vteapp: Unbreak transparency (819 bytes, patch)
2014-05-09 17:44 UTC, Debarshi Ray 		none Details | Review
vteapp: Unbreak transparency (832 bytes, patch)
2014-05-12 08:48 UTC, Debarshi Ray 		none Details | Review
vteapp: Unbreak transparency (884 bytes, patch)
2014-05-12 08:52 UTC, Debarshi Ray 		none Details | Review
[vte-0-36] vteapp: Unbreak transparency (864 bytes, patch)
2014-05-12 08:59 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-05-09 16:30:34 UTC 
The following gtk+ commit broke the -T option in the vte test application. Reverting it makes the -T option work on vte-0-36, but not in master.

commit 3c2c3ab6f9335f8e7592041ca6ce7490ede62eeb
Author: Jasper St. Pierre <jstpierre@mecheye.net>
Date:   Thu Aug 22 13:20:10 2013 -0400

    gtkwindow: Calculate the opaque window based off of the style
    
    https://bugzilla.gnome.org/show_bug.cgi?id=706922

After vte_terminal_set_opacity was removed, the alpha channel of the background colour is used to control the opacity, but that is not set in vte_terminal_set_colors. This is presumably a fallout from this vte commit:

commit 060850078a53dce64c3d2b96882f525fef7f5028
Author: Christian Persch <chpe@gnome.org>
Date:   Fri Apr 4 10:26:00 2014 +0200

    widget: Remove unused tint colour
Comment 1 Debarshi Ray 2014-05-09 16:34:13 UTC 
Created attachment 276252 [details] [review]
widget: Set the background alpha in set_colors
Comment 2 Debarshi Ray 2014-05-09 16:44:08 UTC 
Created attachment 276255 [details] [review]
widget: Set the background alpha in set_colors
Comment 3 Christian Persch 2014-05-09 16:54:00 UTC 
*** Bug 728675 has been marked as a duplicate of this bug. ***
Comment 4 Debarshi Ray 2014-05-09 16:55:25 UTC 
Comment on attachment 276255 [details] [review]
widget: Set the background alpha in set_colors

Thanks for the review.
Comment 5 Debarshi Ray 2014-05-09 17:44:31 UTC 
Created attachment 276256 [details] [review]
vteapp: Unbreak transparency
Comment 6 Debarshi Ray 2014-05-12 08:48:18 UTC 
Created attachment 276365 [details] [review]
vteapp: Unbreak transparency
Comment 7 Debarshi Ray 2014-05-12 08:52:32 UTC 
Created attachment 276366 [details] [review]
vteapp: Unbreak transparency
Comment 8 Debarshi Ray 2014-05-12 08:59:41 UTC 
Created attachment 276367 [details] [review]
[vte-0-36] vteapp: Unbreak transparency
Comment 9 Debarshi Ray 2014-05-12 09:05:17 UTC 
Comment on attachment 276366 [details] [review]
vteapp: Unbreak transparency

chpe committed already committed a similar fix:

commit 4431fd96c2224988ec844cb7cfd3e947b1d819b4
Author: Christian Persch <chpe@gnome.org>
Date:   Sun May 11 10:18:04 2014 +0200

    vteapp: Only install argb visual when required by options
Comment 10 Debarshi Ray 2014-05-12 09:05:59 UTC 
Review of attachment 276367 [details] [review]:

Approved by chpe in #vte on GIMPNet:

08:52 <rishi> chpe: Does bug 729884 look better now?
08:52 <Services> Bug http://bugzilla.gnome.org/show_bug.cgi?id=729884 normal,   
      Normal, ---, vte-maint, UNCONFIRMED, Unbreak vte-2.91 -T
09:00 <chpe> rishi: the master one shouldn't be necessary anymore, I already    
      fixed it there. please do commit the 0-36 one