After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729817 - GtkCellLayout: allow finding attributes at runtime
GtkCellLayout: allow finding attributes at runtime
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-05-08 14:17 UTC by Matthias Clasen
Modified: 2014-05-08 18:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkCellLayout: allow finding attributes at runtime (7.33 KB, patch)
2014-05-08 14:17 UTC, Matthias Clasen 		none Details | Review
GtkCellArea: allow finding attributes at runtime (2.63 KB, patch)
2014-05-08 18:11 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2014-05-08 14:17:47 UTC 
This will allow e.g. GtkInspector to display attribute mappings.
Comment 1 Matthias Clasen 2014-05-08 14:17:55 UTC 
Created attachment 276165 [details] [review]
GtkCellLayout: allow finding attributes at runtime
Comment 2 Tristan Van Berkom 2014-05-08 17:43:31 UTC 
The patch looks fine and correct for GtkCellLayout/GtkCellArea.

One minor nitpick:

+  if (GTK_CELL_LAYOUT_GET_IFACE (cell_layout)->get_attribute)
+    return GTK_CELL_LAYOUT_GET_IFACE (cell_layout)->get_attribute (cell_layout, cell, attribute);

The check is unneeded since you provide a default implementation, I wouldnt have mentioned this except that it seems to be inconsistent with the rest of gtkcelllayout.c so maybe better to follow the style there.
Comment 3 Matthias Clasen 2014-05-08 18:11:52 UTC 
Created attachment 276185 [details] [review]
GtkCellArea: allow finding attributes at runtime

This will allow e.g. GtkInspector to display attribute mappings.

http://bugzilla.gnome.org/show_bug.cgi?id=729817
Comment 4 Matthias Clasen 2014-05-08 18:12:15 UTC 
Attachment 276185 [details] pushed as f4d02bd - GtkCellArea: allow finding attributes at runtime