After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729809 - listbox: Add missing ::row-selected emissions
listbox: Add missing ::row-selected emissions
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-05-08 10:29 UTC by Florian Müllner
Modified: 2014-08-03 21:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
listbox: Add missing ::row-selected emissions (3.61 KB, patch)
2014-05-08 10:29 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-05-08 10:29:51 UTC 
See patch. I'm a bit unsure about the emissions in update_selection() for MULTIPLE (in particular when unselecting a row while there are still other rows selected), but at least the rest should be straightforward.
Comment 1 Florian Müllner 2014-05-08 10:29:54 UTC 
Created attachment 276148 [details] [review]
listbox: Add missing ::row-selected emissions

Rows are not necessarily selected via select_row_internal(), add
the missing signal emissions there. Also the signal should be emitted
when removing the selection altogether.
Comment 2 Matthias Clasen 2014-05-11 01:49:08 UTC 
I'd like to see a testcase that shows the missing emissions.
Comment 3 Matthias Clasen 2014-08-03 21:19:10 UTC 
Attachment 276148 [details] pushed as 6f857f8 - listbox: Add missing ::row-selected emissions