GNOME Bugzilla – Bug 729702
Support automatic proxy
Last modified: 2021-05-17 16:07:02 UTC
It would be good to support the G_DESKTOP_PROXY_MODE_AUTO proxy mode. This could be implemented using GProxyResolver rather than reading the proxy settings directly. The Resolver would have to be queried inside SjMetadataMusicbrainz5 rather than SjMetadata as g_proxy_resolver_lookup() needs a url. That would make the proxy properties of SjMetadata redundant. Christophe wasn't keen when I tried to move the proxy handling into SjMetadataMusicbrainz5 and remove the properties from SjMetadata before but it would be good to support the auto proxy mode. Also we should think about what to do with the http_proxy environment variable. If it's set then libmusicbrainz uses it if mb5_query_set_proxyhost() isn't called or is called with NULL. That means if a user starts sound-juicer and then sets the proxy mode to 'none' sound-juicer will still use the proxy as the http_proxy environment variable will still be set.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/sound-juicer/-/issues/161.