After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729636 - Only show title button separator when there is something to separate them from
Only show title button separator when there is something to separate them from
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 733910 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-05-06 10:46 UTC by lamefun
Modified: 2014-08-29 15:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Only show title button separator when there is something to separate them from (3.16 KB, patch)
2014-05-06 10:46 UTC, lamefun 		reviewed Details | Review

Description lamefun 2014-05-06 10:46:41 UTC 
Created attachment 275963 [details] [review]
Only show title button separator when there is something to  separate them from

patch
Comment 1 Matthias Clasen 2014-05-11 13:37:08 UTC 
I don't particularly like this - updating the separator visibility from size allocate seems wrong. There's also no guarantee that a visible child means 'something to separate from' - it could just be an empty box.

If we want to do something like this, I'd rather have the headerbar keep track of whether it has any pack-start/pack-end children, instead of looping over them all the time.

Finally, if separator visibility is internally controlled, they need to have no-show-all set on them, else an innocent gtk_widget_show_all might make them appear unintentionally.
Comment 2 Matthias Clasen 2014-05-11 13:37:38 UTC 
Review of attachment 275963 [details] [review]:

.
Comment 3 Matthias Clasen 2014-07-30 20:57:48 UTC 
*** Bug 733910 has been marked as a duplicate of this bug. ***
Comment 4 Matthias Clasen 2014-08-01 13:36:02 UTC 
*** Bug 733910 has been marked as a duplicate of this bug. ***
Comment 5 Matthias Clasen 2014-08-29 15:02:44 UTC 
this has been done noe