After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729621 - Common X11 check only looks for X11/Xlib.h, not for libX11
Common X11 check only looks for X11/Xlib.h, not for libX11
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: common
unspecified
Other All
: Normal normal
: 1.3.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-05-06 07:08 UTC by LRN
Modified: 2014-05-06 15:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
X11 check: look for libX11 as well as Xlib.h (991 bytes, patch)
2014-05-06 07:08 UTC, LRN 		reviewed Details | Review
base: Use X11 detection macro from gst-common (1.60 KB, patch)
2014-05-06 08:08 UTC, LRN 		committed Details | Review
good: use X11 detection macro from gst-common (1.84 KB, patch)
2014-05-06 09:22 UTC, LRN 		reviewed Details | Review
m4: in X11 check for libX11 as well as Xlib.h (992 bytes, patch)
2014-05-06 15:35 UTC, Luis de Bethencourt 		committed Details | Review
configure: Use X11 detection macro from common (1.61 KB, patch)
2014-05-06 15:41 UTC, Luis de Bethencourt 		committed Details | Review
configure: use X11 detection macro from common (1.84 KB, patch)
2014-05-06 15:44 UTC, Luis de Bethencourt 		committed Details | Review

Description LRN 2014-05-06 07:08:50 UTC 
Consequences are the same as in bug 729513
Comment 1 LRN 2014-05-06 07:08:53 UTC 
Created attachment 275940 [details] [review]
X11 check: look for libX11 as well as Xlib.h
Comment 2 LRN 2014-05-06 08:08:55 UTC 
Created attachment 275945 [details] [review]
base: Use X11 detection macro from gst-common
Comment 3 LRN 2014-05-06 09:22:34 UTC 
Created attachment 275952 [details] [review]
good: use X11 detection macro from gst-common
Comment 4 Luis de Bethencourt 2014-05-06 14:46:38 UTC 
Testing.
Comment 5 Luis de Bethencourt 2014-05-06 15:14:05 UTC 
It works here, and I have reworded the commits in my local branches.

Anybody wants to join the review before I push?
Comment 6 Luis de Bethencourt 2014-05-06 15:35:53 UTC 
The following fix has been pushed:
1f5d3c3 m4: in X11 check for libX11 as well as Xlib.h
Comment 7 Luis de Bethencourt 2014-05-06 15:35:57 UTC 
Created attachment 275992 [details] [review]
m4: in X11 check for libX11 as well as Xlib.h
Comment 8 Luis de Bethencourt 2014-05-06 15:40:55 UTC 
The following fix has been pushed:
2d0ecd7 configure: Use X11 detection macro from common
Comment 9 Luis de Bethencourt 2014-05-06 15:41:01 UTC 
Created attachment 275993 [details] [review]
configure: Use X11 detection macro from common
Comment 10 Luis de Bethencourt 2014-05-06 15:44:03 UTC 
The following fix has been pushed:
1d17ed1 configure: use X11 detection macro from common
Comment 11 Luis de Bethencourt 2014-05-06 15:44:06 UTC 
Created attachment 275995 [details] [review]
configure: use X11 detection macro from common