GNOME Bugzilla – Bug 729453
t/GtkCellRenderer.t sometimes fails on armhf, mips and mipsel architectures
Last modified: 2014-11-16 13:53:33 UTC
Hi, since April 2010 (1.1.221), libgtk2-perl sometimes fails to build from source in Debian, on the armhf, mips and mipsel architectures, due to a failing test (t/GtkCellRenderer.t). I did not find any similar failure on other architectures. This is tracked in Debian as https://bugs.debian.org/746761. Any idea what could be wrong? Build logs on mips: https://buildd.debian.org/status/fetch.php?pkg=libgtk2-perl&arch=mips&ver=2:1.249-1&stamp=1389205083 https://buildd.debian.org/status/fetch.php?pkg=libgtk2-perl&arch=mips&ver=2:1.249-2&stamp=1395691192 https://buildd.debian.org/status/fetch.php?pkg=libgtk2-perl&arch=mips&ver=1:1.230-1&stamp=1278406057 https://buildd.debian.org/status/fetch.php?pkg=libgtk2-perl&arch=mips&ver=1:1.230-1&stamp=1278278634 https://buildd.debian.org/status/fetch.php?pkg=libgtk2-perl&arch=mips&ver=1:1.221-6&stamp=1271111575 Build logs on mipsel: https://buildd.debian.org/status/fetch.php?pkg=libgtk2-perl&arch=mipsel&ver=2:1.247-2+b1&stamp=1378112269 https://buildd.debian.org/status/fetch.php?pkg=libgtk2-perl&arch=mipsel&ver=2:1.242-1&stamp=1327181795 Build logs on armhf: https://buildd.debian.org/status/fetch.php?pkg=libgtk2-perl&arch=armhf&ver=2:1.247-1&stamp=1360945938
Note that the failing test is: is_deeply ([ sort keys %hits ], [ qw/edit init render size/ ], 'callbacks encountered'); The following similar line succeeds: is_deeply ([ sort keys %hits_compat ], [ qw/edit init render size/ ], 'callbacks encountered'); The second line performs callback test in compat mode (quoting the comment in the test: "in the style of 1.02x") which succeeds. The first line test callback in newer mode and fails. This looks like a regression. HTH
Created attachment 283031 [details] [review] Make t/GtkCellRenderer.t more robust The tests that check that all vfuncs of custom cell renderers are called appropriately were relying on certain behavior of gtk+. Apparently, that is not appropriate on all platforms, as we have failure reports from armhf, mips and mipsel. Make the tests more robust by triggering all vfuncs on all custom renderers manually.
Please try the above patch. I think it should fix the failures.
(In reply to comment #3) > Please try the above patch. I think it should fix the failures. Thanks! Uploaded to Debian. We'll know in a few hours if it passes the tests fine once, but given the failure can't be reproduced every time, we'll have to wait for a few more uploads before we're sure the problem is really fixed.
The build status on <https://buildd.debian.org/status/package.php?p=libgtk2-perl> looks all green now, so: Attachment 283031 [details] pushed as e8005ee - Make t/GtkCellRenderer.t more robust