After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729375 - power: Fix wakeup with some keymaps
power: Fix wakeup with some keymaps
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: power
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2014-05-02 10:30 UTC by Bastien Nocera
Modified: 2014-05-05 13:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
power: Fix wakeup with some keymaps (2.20 KB, patch)
2014-05-02 10:30 UTC, Bastien Nocera 		accepted-commit_now Details | Review
power: Fix wakeup with some keymaps (2.33 KB, patch)
2014-05-05 13:37 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2014-05-02 10:30:00 UTC 
.
Comment 1 Bastien Nocera 2014-05-02 10:30:12 UTC 
Created attachment 275630 [details] [review]
power: Fix wakeup with some keymaps

When trying to wake up the screen, try to use XF86WakeUp in preference
to the left Alt. Don't use the right Alt key as it might be set as the
Compose key which would eat the event without resetting the idle.
Comment 2 Rui Matos 2014-05-02 13:19:49 UTC 
Review of attachment 275630 [details] [review]:

This keysym seems to work correctly.

::: plugins/power/gpm-common.c
@@ +750,1 @@
         if (inited == FALSE) {

Not introduced in this patch, but this inited variable is never set to TRUE. I'd just use a 0 keycode value for the check and ditch this.
Comment 3 Bastien Nocera 2014-05-05 13:37:33 UTC 
Created attachment 275888 [details] [review]
power: Fix wakeup with some keymaps

When trying to wake up the screen, try to use XF86WakeUp in preference
to the left Alt. Don't use the right Alt key as it might be set as the
Compose key which would eat the event without resetting the idle.

Also make sure to initialise the keycode only once.
Comment 4 Bastien Nocera 2014-05-05 13:50:49 UTC 
Pushed from gnome-3-8 all the way to master.

Attachment 275888 [details] pushed as 199c995 - power: Fix wakeup with some keymaps