After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 729284 - [review] dcbw/rh1091296-dispatcher: dispatch dhcp-change events when slower IP completes
[review] dcbw/rh1091296-dispatcher: dispatch dhcp-change events when slower I...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: IP and DNS config
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-04-30 19:40 UTC by Dan Williams
Modified: 2014-05-09 20:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-core-emit-dhcp4-dhcp6-change-dispatcher-events-if-ot.patch (3.51 KB, patch)
2014-04-30 19:40 UTC, Dan Williams 		accepted-commit_now Details | Review

Description Dan Williams 2014-04-30 19:40:50 UTC 
Created attachment 275506 [details] [review]
0001-core-emit-dhcp4-dhcp6-change-dispatcher-events-if-ot.patch

If one IP version was slower to complete and the device had already entered the ACTIVATED state, the slower IP version's DHCP information wouldn't be pushed to dispatcher scripts until the first lease renew.

The commit is also attached as a patch for easier review.
Comment 1 Dan Winship 2014-05-01 13:04:16 UTC 
Comment on attachment 275506 [details] [review]
0001-core-emit-dhcp4-dhcp6-change-dispatcher-events-if-ot.patch

appears to fix the bug, but isn't there another problem, where if IPv4 finishes first, and IPv6 uses SLAAC rather than DHCP, then the dispatcher never gets the IPv6 info?
Comment 2 Dan Williams 2014-05-01 18:13:07 UTC 
Yes, that is an issue (though not a regression).

A possible solution for that is to create separate dispatcher "up4" and "up6" events that get triggered from the same place as these dhcp-change events when the IP state changes from CONF -> DONE.  But I thought that was out-of-scope for the current bug, so I left that out.  Pretty simple fix though.
Comment 3 Thomas Haller 2014-05-02 20:35:00 UTC 
LGTM

Acked-by: Thomas Haller <thaller@redhat.com>
Comment 4 Dan Williams 2014-05-09 20:26:01 UTC 
pushed to master after rebase