GNOME Bugzilla – Bug 729245
gl: rename platform cocoa to cgl to be more consistent with context type
Last modified: 2014-05-27 08:08:45 UTC
1- we should rename GST_GL_HAVE_PLATFORM_COCOA to GST_GL_HAVE_PLATFORM_CGL: http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglcontext.c#n214 to uniform with name used with gst_gl_context_get_gl_platform which return GST_GL_PLATFORM_CGL http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/cocoa/gstglcontext_cocoa.m#n348 Those enum are defined here: http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglapi.h#n117 That would also make more sense to do GST_GL_PLATFORM=cgl GST_GL_WINDOW=cocoa instead of GST_GL_PLATFORM=cocoa GST_GL_WINDOW=cocoa videotestsrc ! glimagesink Also on the cocoa doc you can read: "Every NSOpenGLContext object wraps a low-level, platform-specific Core OpenGL (CGL) context. Your application can retrieve the CGL context by calling the CGLContextObj method.", cf: https://developer.apple.com/library/mac/documentation/cocoa/reference/applicationkit/classes/NSOpenGLContext_Class/Reference/Reference.html 2 -missing context type CGL (and EAGL): http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglcontext.h#n50
if that make sense to do this change, I think this bug should be marked as blocker
Sure, it makes sense.
commit ce4a2b68286f505c3caa77501fd63ab10f139fd9 Author: Julien Isorce <julien.isorce@gmail.com> Date: Tue May 27 08:54:20 2014 +0100 gl: add missing cgl and eagl context type https://bugzilla.gnome.org/show_bug.cgi?id=729245 commit fbe6dd9c5f645ba2af050d46b080dc180c37c165 Author: Julien Isorce <julien.isorce@gmail.com> Date: Tue May 27 08:46:16 2014 +0100 gl: rename platform cocoa to cgl Before: GST_GL_PLATFORM=cocoa GST_GL_WINDOW=cocoa gst-launch-1.0 videotestsrc ! glimagesink After: GST_GL_PLATFORM=cgl GST_GL_WINDOW=cocoa gst-launch-1.0 videotestsrc ! glimagesink but still pass --enable-cocoa to configure script because currently it can only be used with cocoa API. We could later have cgl/gstglcontext_cgl.h that manages a CGLContextObj directly and cocoa/gstglcontext_cocoa.h would just wrap it. So that it could be used with other Apple's window APIs. https://bugzilla.gnome.org/show_bug.cgi?id=729245