Created attachment 275281 [details] [review]
Proposd patch

Comment on attachment 275281 [details] [review]
Proposd patch

> This is practical for building in very sparse environment like Heroku,
> where pulling in gtk-doc requires building many more dependencies.

Are you building from git or from tarballs?

>+        echo "*** No GTK-Doc found, you will not be able to create API documentation***"
>+        echo 'EXTRA_DIST =' > gtk-doc.make

disted tarballs should always include built documentation, so if don't have gtk-doc, then "make dist" should fail (as it does if you --disable-gtk-doc).

>+else
>+        gtkdocize
> fi
> 
>-gtkdocize || exit $?

should keep the "|| exit $?" so that gtkdocize failure causes autogen.sh to fail

>+AM_CONDITIONAL([ENABLE_GTK_DOC], false)

it's more like HAVE_GTK_DOC, not ENABLE_GTK_DOC...

>diff --git a/docs/Makefile.am b/docs/Makefile.am
>diff --git a/docs/reference/Makefile.am b/docs/reference/Makefile.am

It seems like you should only need to modify one or the other of these Makefiles.

[mass-moving all "UNCONFIRMED" libsoup bugs to "NEW" after disabling the "UNCONFIRMED" status for this product now that bugzilla.gnome.org allows that. bugspam-libsoup-20150210]

This will be obsolete once we move to Meson and the Autotools support will be removed. The meson port allows building without documentation with -Ddoc=false

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libsoup/issues/76.