After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728970 - rtsp-client: add signal before sending response
rtsp-client: add signal before sending response
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-25 19:44 UTC by Aleix Conchillo Flaqué
Modified: 2014-05-01 05:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
new send-response signal (8.04 KB, patch)
2014-04-25 19:50 UTC, Aleix Conchillo Flaqué 		none Details | Review
new send-message signal (8.06 KB, patch)
2014-04-25 20:39 UTC, Aleix Conchillo Flaqué 		rejected Details | Review

Description Aleix Conchillo Flaqué 2014-04-25 19:44:27 UTC 
Currently, client has a signal for each of the request. The signals are emitted after the request has been performed (except TEARDOWN).

However, it would be great that we could modify the RTSP messages before being send to the client.
Comment 1 Aleix Conchillo Flaqué 2014-04-25 19:50:57 UTC 
Created attachment 275163 [details] [review]
new send-response signal

this patch adds a new "send-response" signal which gets emitted before an RTSP message is to be sent to the client. this allows latest modifications to the message.
Comment 2 Aleix Conchillo Flaqué 2014-04-25 20:39:41 UTC 
Created attachment 275165 [details] [review]
new send-message signal

just renamed "send-response" to "send-message". i think it makes more sense.
Comment 3 Wim Taymans 2014-05-01 04:21:11 UTC 
I reworked it a bit. There is no need to send the message type, it's already inside the message itself. I also passed the context.

commit ea4543efc810f9347196ece13e8c2168b82073eb
Author: Wim Taymans <wtaymans@redhat.com>
Date:   Thu May 1 06:17:06 2014 +0200

    client: emit a signal before sending a message
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=728970
Comment 4 Aleix Conchillo Flaqué 2014-05-01 05:22:24 UTC 
Cool. Yes, much easier. Thank you!