GNOME Bugzilla – Bug 728930
Codestyle corrections
Last modified: 2016-03-31 13:22:07 UTC
The appended patch makes the code more readable splitting some long lines (>120 chars) up to two.
Created attachment 275108 [details] [review] Codestyle corrections This corrects the following things in some sources making the code more readable: - lines that exceed 120 characters
Review of attachment 275108 [details] [review]: Looks good otherwise. :) ::: src/i-properties-provider.vala @@ +153,3 @@ + protected Boxes.Property add_property (ref List<Boxes.Property> list, string? name, + Widget widget, Widget? extra_widget = null) { The coding-style is to have 1 argument on each line if dividing the function call/signature into multiple lines. ::: src/libvirt-machine-properties.vala @@ +219,3 @@ } catch (GLib.Error error) { + warning ("Failed to fetch configuration for domain '%s': %s", + machine.domain.get_name (), error.message); same here ::: src/libvirt-system-importer.vala @@ +88,3 @@ + private void get_domain_info (Domain domain, out GVirConfig.Domain config, + out string disk_path) throws GLib.Error { and here ::: src/spice-display.vala @@ +341,3 @@ got_error (msg.printf (device_desc, box_name)); + debug ("Error connecting %s to %s: %s", device_desc, + box_name, err.message); and here ::: src/unattended-installer.vala @@ +66,3 @@ try { + accounts = Bus.get_proxy_sync (BusType.SYSTEM, "org.freedesktop.Accounts", + "/org/freedesktop/Accounts"); and here
Created attachment 275120 [details] [review] Codestyle corrections This corrects the following things in some sources making the code more readable: - lines that exceed 120 characters
Review of attachment 275120 [details] [review]: ACK, I'll modify commit log before merging cause you don't need to make a list if there is only one item in the list. :)
Attachment 275120 [details] pushed as 36ff2c9 - Codestyle corrections