After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728897 - environment: Be more careful when hooking up style properties
environment: Be more careful when hooking up style properties
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-24 17:24 UTC by Florian Müllner
Modified: 2014-04-24 17:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
environment: Be more careful when hooking up style properties (1.50 KB, patch)
2014-04-24 17:24 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-04-24 17:24:47 UTC 
Small drive-by fix, see patch.
Comment 1 Florian Müllner 2014-04-24 17:24:51 UTC 
Created attachment 275072 [details] [review]
environment: Be more careful when hooking up style properties

Sometimes it is more appropriate to set layout properties that are
hooked up to CSS properties in code. However this is currently not
possible, as we end up setting properties to 0 when not found in CSS;
be a bit more careful when hooking up CSS properties to support fix
this.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-04-24 17:29:58 UTC 
Review of attachment 275072 [details] [review]:

"to support fix this"?

Does this break anything in the shell currently, or is this for future stuff? Looks good.
Comment 3 Florian Müllner 2014-04-24 17:35:13 UTC 
Attachment 275072 [details] pushed as 3969be3 - environment: Be more careful when hooking up style properties

(In reply to comment #2)
> Does this break anything in the shell currently, or is this for future stuff?

I'm not aware of any breakage (or any uncommitted code which depends on it); it's just a correctness issue that came up recently in a conversation with Carlos ...