After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728874 - Extra, unselectable dconf option in gsetting description
Extra, unselectable dconf option in gsetting description
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Preferences
git master
Other Linux
: Normal minor
: ---
Assigned To: Robert Roth
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-24 12:54 UTC by Anders Jonsson
Modified: 2015-06-13 08:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.24 KB, patch)
2014-05-02 07:33 UTC, Robert Roth 		none Details | Review
Updated proposed patch (2.54 KB, patch)
2015-06-12 12:46 UTC, Robert Roth 		committed Details | Review

Description Anders Jonsson 2014-04-24 12:54:53 UTC 
In org.gnome.epiphany.gschema.xml.h:31 the string states:
"Toolbar style. Allowed values are \"\" (use GNOME default style), \"both\" (text and icons), \"both-horiz\" (text besides icons), \"icons\", and \"text\"."

However the "" value is not selectable in dconf. Only the four other are listed.

Further checking in gsettings gave the following results:

$ gsettings set org.gnome.Epiphany.ui toolbar-style ""
The provided value is outside of the valid range


$ gsettings range org.gnome.Epiphany.ui toolbar-style
enum
'both'
'both-horiz'
'icons'
'text'

And in /libs/ephy-prefs.h I see:

typedef enum
{
  EPHY_PREFS_UI_TOOLBAR_STYLE_BOTH,
  EPHY_PREFS_UI_TOOLBAR_STYLE_BOTH_HORIZ,
  EPHY_PREFS_UI_TOOLBAR_STYLE_ICONS,
  EPHY_PREFS_UI_TOOLBAR_STYLE_TEXT
} EphyPrefsUIToolbarStyle;


So it looks like the empty string "" not is a valid value for toolbar style.
Comment 1 Robert Roth 2014-05-02 07:33:10 UTC 
Created attachment 275622 [details] [review]
Proposed patch

Removed the "" possible value from the dconf value description.
Comment 2 Michael Catanzaro 2014-08-17 15:47:33 UTC 
Review of attachment 275622 [details] [review]:

I think the real problem is that this setting still exists, since the toolbar was removed in 2012.
Comment 3 Robert Roth 2015-06-12 12:46:55 UTC 
Created attachment 305142 [details] [review]
Updated proposed patch

Removed references to toolbar-style as requested.
Comment 4 Robert Roth 2015-06-13 08:53:21 UTC 
Review of attachment 305142 [details] [review]:

Committed to master.
Comment 5 Robert Roth 2015-06-13 08:56:02 UTC 
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.