After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728812 - GrlPlsFilterFunc is missing from the doc
GrlPlsFilterFunc is missing from the doc
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-23 18:49 UTC by Xavier Claessens
Modified: 2014-04-24 14:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Doc: fix some unused/undeclared symbols (1.67 KB, patch)
2014-04-23 19:19 UTC, Xavier Claessens 		accepted-commit_now Details | Review
GrlPlsFilterFunc: Document how the refcounting works (1.28 KB, patch)
2014-04-23 19:35 UTC, Xavier Claessens 		accepted-commit_now Details | Review
Document that grl_pls_browse can take NULL filter func (1.63 KB, patch)
2014-04-23 19:39 UTC, Xavier Claessens 		accepted-commit_now Details | Review

Description Xavier Claessens 2014-04-23 18:49:47 UTC 
GrlPlsFilterFunc is missing from grilo-sections.txt and does not appear in devhelp.
Comment 1 Xavier Claessens 2014-04-23 19:19:57 UTC 
Created attachment 274984 [details] [review]
Doc: fix some unused/undeclared symbols
Comment 2 Xavier Claessens 2014-04-23 19:23:14 UTC 
Note that there are more unused symbols but I'm wondering if they are supposed to be public API. See doc/grilo/grilo-unused.txt when building with --enable-gtk-doc.
Comment 3 Xavier Claessens 2014-04-23 19:35:38 UTC 
Created attachment 274985 [details] [review]
GrlPlsFilterFunc: Document how the refcounting works
Comment 4 Xavier Claessens 2014-04-23 19:39:13 UTC 
Created attachment 274986 [details] [review]
Document that grl_pls_browse can take NULL filter func
Comment 5 Bastien Nocera 2014-04-24 09:13:21 UTC 
Review of attachment 274984 [details] [review]:

Looks good
Comment 6 Bastien Nocera 2014-04-24 09:15:14 UTC 
Review of attachment 274985 [details] [review]:

Looks good otherwise.

::: libs/pls/grl-pls.h
@@ +39,3 @@
  * grl_pls_browse_sync() or grl_pls_browse_by_spec().
  *
+ * The callback is responsible to unref @media when returning %NULL or another

"is responsible for unreffing"
Comment 7 Bastien Nocera 2014-04-24 09:16:05 UTC 
Review of attachment 274986 [details] [review]:

Please prefix the subject line of the commit message as was done before.
Comment 8 Xavier Claessens 2014-04-24 14:57:25 UTC 
Thanks, all fixed and pushed.