After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728810 - W32: Modelbuttons look like buttons
W32: Modelbuttons look like buttons
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-04-23 16:45 UTC by LRN
Modified: 2014-04-24 03:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
W32: Add modelbutton styles (2.03 KB, patch)
2014-04-23 16:46 UTC, LRN 		none Details | Review
Before: modelbutton looks like a button (5.14 KB, image/png)
2014-04-23 16:47 UTC, LRN 		  Details
After: modelbutton looks flat (4.44 KB, image/png)
2014-04-23 17:17 UTC, LRN 		  Details
W32: Add modelbutton styles (3.91 KB, patch)
2014-04-23 17:18 UTC, LRN 		committed Details | Review
After (v2): modelbutton looks like a menu item (19.41 KB, image/png)
2014-04-23 17:26 UTC, LRN 		  Details

Description LRN 2014-04-23 16:45:57 UTC 
Seems like modelbuttons use the .button style
The name is misleading. As far as i've been told, modelbuttons should
look flat, like menu items.
Comment 1 LRN 2014-04-23 16:46:02 UTC 
Created attachment 274969 [details] [review]
W32: Add modelbutton styles

According to what i've been told, modelbuttons are supposed to look
flat, like menu items. This does the trick, at least as far as
gtk3-widget-factory is concerned. May need to be extended to model
radio buttons as well.
Comment 2 LRN 2014-04-23 16:47:00 UTC 
Created attachment 274970 [details]
Before: modelbutton looks like a button
Comment 3 LRN 2014-04-23 17:17:32 UTC 
Created attachment 274972 [details]
After: modelbutton looks flat
Comment 4 LRN 2014-04-23 17:18:53 UTC 
Created attachment 274973 [details] [review]
W32: Add modelbutton styles

According to what i've been told, modelbuttons are supposed to look
flat, like menu items.

This is basically an improved copy of the menuitem styles.

v2: instead of just not drawing anything, draw it really like a menu
    item (copied and edited manuitem styles for that purpose)
Comment 5 LRN 2014-04-23 17:26:57 UTC 
Created attachment 274974 [details]
After (v2): modelbutton looks like a menu item
Comment 6 Matthias Clasen 2014-04-23 18:13:26 UTC 
Review of attachment 274973 [details] [review]:

looks much better to me, thanks
Comment 7 LRN 2014-04-24 03:42:28 UTC 
Attachment 274973 [details] pushed as 37aa840 - W32: Add modelbutton styles