After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728665 - fix or remove trie matcher
fix or remove trie matcher
Status: RESOLVED OBSOLETE
Product: vte
Classification: Core
Component: general
0.36.x
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-21 16:31 UTC by Christian Persch
Modified: 2015-02-10 18:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Christian Persch 2014-04-21 16:31:27 UTC 
Since we always use emulation="xterm", _vte_matcher_create() always uses the table matcher, and never the trie matcher.

Experimentally using the trie matcher totally broke the terminal, so it seems trie doesn't work (anymore? or just not for "xterm"?). We either need to fix it, or simply remove it.
Comment 1 Egmont Koblinger 2014-04-28 11:22:38 UTC 
You've just removed tons of features that would have been useful for some users (e.g. transparency, custom word chars). I haven't heard anyone complaining about broken non-xterm emulation or broken trie matcher. So why wondering about fixing vs removing? IMO please just go ahead and remove :)
Comment 2 Christian Persch 2014-05-20 14:16:43 UTC 
trie removed.

Now that only table remains, can also dispose of the vte_matcher_impl indirection and just use table directly.
Comment 3 Egmont Koblinger 2014-05-20 14:56:39 UTC 
Funny thing is, I had literally the exact change prepared, including renaming the debug variable, dropping the fixme. :) Sorry I didn't submit! I wanted to go ahead and remove the indirection too, but that seems to be much harder.