After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728327 - g_settings_schema_source_lookup misses (allow-none) annotation
g_settings_schema_source_lookup misses (allow-none) annotation
Status: RESOLVED DUPLICATE of bug 730493
Product: glib
Classification: Platform
Component: gsettings
unspecified
Other All
: Normal normal
: ---
Assigned To: Allison Karlitskaya (desrt)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-04-16 09:52 UTC by Alberto Ruiz
Modified: 2017-03-09 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes the annotation problem (760 bytes, patch)
2014-04-16 09:52 UTC, Alberto Ruiz 		rejected Details | Review

Description Alberto Ruiz 2014-04-16 09:52:21 UTC 
Created attachment 274441 [details] [review]
Fixes the annotation problem

g_settings_schema_source_lookup does not report that its return value is nullable
Comment 1 Allison Karlitskaya (desrt) 2014-04-16 11:49:32 UTC 
I think we still haven't decided what (allow none) means on return values...
Comment 2 Alberto Ruiz 2014-04-16 12:02:32 UTC 
It means "or %NULL" :-)

Seriously though, Vala is adding custom metadata to vapigen to do the right thing here and describe the return value as nullable, we're supposed to use the gir to annotate these things right? Or is the idea here maybe assume it is always nullable and have an annotation for return values that cannot be null?
Comment 3 Allison Karlitskaya (desrt) 2014-04-16 12:15:24 UTC 
See bug 660879 and bug 626395, at least.
Comment 4 Allison Karlitskaya (desrt) 2014-04-16 23:55:51 UTC 
Review of attachment 274441 [details] [review]:

Hopefully soon we will have a proper (nullable) attribute.  See bug 660879.
Comment 5 Matthias Clasen 2017-03-08 18:29:08 UTC 
not an os x issue. the patch should be redone using nullable
Comment 6 Philip Withnall 2017-03-09 14:06:23 UTC 
This was actually fixed already by commit 570b27b9acbf6e6f31ab0f9a31a4cce60f4d228a, bug #730493.

*** This bug has been marked as a duplicate of bug 730493 ***