After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728254 - Incorrect item is removed in playlists if it has duplicates
Incorrect item is removed in playlists if it has duplicates
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.12.x
Other Linux
: Normal normal
: 3.14
Assigned To: gnome-music-maint
gnome-music-maint
available
Depends on:
Blocks:
 
 
Reported: 2014-04-15 11:41 UTC by Vadim Rutkovsky
Modified: 2014-06-08 15:44 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12


Description Vadim Rutkovsky 2014-04-15 11:41:24 UTC 
STR:
1) Add the same URI several times to a playlist
2) Select second instance of the duplicated item in playlist
3) Remove selected item
Result: first instance is removed

This happens due to the fact that we're passing the song uri to _on_song_removed_from_playlist and looking for this uri in the model one by one. We should pass iter instead
Comment 1 Arnel Borja 2014-05-01 06:59:06 UTC 
I think it's better if we use Tracker id's for this, so all views have a similar code. Unfortunately, we can't because of the implementation's limitations, but we could use Tracker instead. See bug 729311.
Comment 2 Arnel Borja 2014-06-08 15:44:34 UTC 
Fixed by porting playlists to Tracker and using Tracker ID's to look for the correct item. https://git.gnome.org/browse/gnome-music/commit/?id=14e9b27de632bd250e5dc7248816280b0272205b