After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728202 - Do not allow manual access to ChessGame.clock
Do not allow manual access to ChessGame.clock
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
3.12.x
Other Linux
: High normal
: ---
Assigned To: Michael Catanzaro
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-14 18:11 UTC by Michael Catanzaro
Modified: 2014-07-06 17:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Do not directly pause/unpause the chess clock (3.87 KB, patch)
2014-07-06 17:11 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2014-04-14 18:11:44 UTC
Currently, we manually stop and start the chess clock when displaying the resign and claim draw dialogs, in order to avoid displaying the pause game overlay.  This is risky since it avoids setting ChessGame.is_paused, which no longer means what it ought to mean.  Decouple the state of this variable from the display of the pause game overlay to avoid resulting bugs (e.g. the chess engine may make a move even while these dialogs are displayed).
Comment 1 Michael Catanzaro 2014-07-06 17:11:01 UTC
The following fix has been pushed:
a4148ca Do not directly pause/unpause the chess clock

Still possible to do this, but we don't anymore.
Comment 2 Michael Catanzaro 2014-07-06 17:11:04 UTC
Created attachment 280003 [details] [review]
Do not directly pause/unpause the chess clock