After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728060 - rtsp-session-pool: Incorrect annotation and leak in unit test
rtsp-session-pool: Incorrect annotation and leak in unit test
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-11 22:01 UTC by Linus Svensson
Modified: 2014-04-12 04:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (5.39 KB, patch)
2014-04-11 22:10 UTC, Linus Svensson 		committed Details | Review

Description Linus Svensson 2014-04-11 22:01:27 UTC 
When a session is created from the pool, the caller gets a reference to the session object. I will attach a patch that corrects the annotation and also fixes some memory leaks in the unit test.
Comment 1 Linus Svensson 2014-04-11 22:10:54 UTC 
Created attachment 274137 [details] [review]
Proposed patch
Comment 2 Wim Taymans 2014-04-12 04:15:28 UTC 
commit 9219509bcfbc84b6c9d826b60b1d88f1619f016e
Author: Linus Svensson <linusp.svensson@gmail.com>
Date:   Fri Apr 11 23:52:49 2014 +0200

    rtsp-session-pool: Fixes annotation
    
    Fixes annotation for gst_rtsp_session_pool_create() and memory leaks
    in the sessionpool test.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=728060