After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727996 - Use UNIX permissions when available
Use UNIX permissions when available
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: fuse
1.20.x
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-10 20:35 UTC by Ross Lagerwall
Modified: 2014-04-11 16:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fuse: Set permissions from UNIX mode when available (2.52 KB, patch)
2014-04-10 20:37 UTC, Ross Lagerwall
committed Details | Review

Description Ross Lagerwall 2014-04-10 20:35:08 UTC
Some programs (eg vim) create a new file based on an existing file's permissions when saving. Because the fuse daemon only set's the owner's permissions, editing a file over sftp using vim makes it save with 0600 permissions, which is annoying.

See the downstream bug: https://bugs.launchpad.net/ubuntu/+source/gvfs/+bug/227808
Comment 1 Ross Lagerwall 2014-04-10 20:37:38 UTC
Created attachment 274040 [details] [review]
fuse: Set permissions from UNIX mode when available

If the GFileInfo has a UNIX mode available, use that for setting
permissions.  This prevents programs like vim from losing permissions
when saving a file.
Comment 2 Ondrej Holy 2014-04-11 10:32:19 UTC
Review of attachment 274040 [details] [review]:

Looks good, thanks!
Comment 3 Ross Lagerwall 2014-04-11 16:56:25 UTC
Pushed to master as 9fe664597834114e8a42dbe09c3b2395affd272b and stable as 9cadf28df7d2476a155ed79a37de73587cb65c69.  Thanks!