After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727983 - Name all the timeouts and idles
Name all the timeouts and idles
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-10 17:28 UTC by Bastien Nocera
Modified: 2014-04-10 19:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
js: Name all the timeouts and idles (34.97 KB, patch)
2014-04-10 17:28 UTC, Bastien Nocera 		reviewed Details | Review
src: Name all the timeouts and idles (11.03 KB, patch)
2014-04-10 17:28 UTC, Bastien Nocera 		committed Details | Review
js: Name all the timeouts and idles (34.97 KB, patch)
2014-04-10 17:39 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2014-04-10 17:28:01 UTC 
.
Comment 1 Bastien Nocera 2014-04-10 17:28:11 UTC 
Created attachment 274019 [details] [review]
js: Name all the timeouts and idles

With very uninventive names. Names now, good names later.
Comment 2 Bastien Nocera 2014-04-10 17:28:18 UTC 
Created attachment 274020 [details] [review]
src: Name all the timeouts and idles
Comment 3 Giovanni Campagna 2014-04-10 17:37:08 UTC 
Review of attachment 274019 [details] [review]:

GLib.source_set_name_by_id() is the deprecated name, the new way to call it is GLib.Source.set_name_by_id(). It's the same signature, so a simple sed should be enough.
Thanks for the patch, btw.
Comment 4 Giovanni Campagna 2014-04-10 17:38:02 UTC 
Review of attachment 274020 [details] [review]:

Sure.
Comment 5 Bastien Nocera 2014-04-10 17:39:38 UTC 
Created attachment 274022 [details] [review]
js: Name all the timeouts and idles

With very uninventive names. Names now, good names later.
Comment 6 Jasper St. Pierre (not reading bugmail) 2014-04-10 18:33:18 UTC 
Review of attachment 274022 [details] [review]:

Yep.
Comment 7 Bastien Nocera 2014-04-10 19:12:06 UTC 
I've also split out a fix that ended up in the js patch into a separate commit.

Attachment 274020 [details] pushed as 85f811f - src: Name all the timeouts and idles
Attachment 274022 [details] pushed as cd2bd76 - js: Name all the timeouts and idles