After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727889 - mxf: avoid dereferencing NULL pointer and leak fixes
mxf: avoid dereferencing NULL pointer and leak fixes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-09 12:24 UTC by Vincent Penquerc'h
Modified: 2014-04-16 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
NULL dereference and leak fix (1.58 KB, patch)
2014-04-09 12:24 UTC, Vincent Penquerc'h
committed Details | Review

Description Vincent Penquerc'h 2014-04-09 12:24:45 UTC
Created attachment 273885 [details] [review]
NULL dereference and leak fix

This still plays the two MXF samples I have, but it's not fully clear it's correct, so here it is in case anyone know what MXF is.
Comment 1 Edward Hervey 2014-04-16 14:09:14 UTC
commit 172c39812726c06b3a922a2a6c2fedc8f333a187
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Wed Apr 9 12:27:16 2014 +0100

    mxf: avoid dereferencing NULL mapping data pointer
    
    Also unref buffers on error, as it seems to be done in one, but
    not all, error paths.
    
    The NULL pointer part is Coverity 206112
    
    https://bugzilla.gnome.org/show_bug.cgi?id=727889