After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727887 - display: Add edge thickness to labeler
display: Add edge thickness to labeler
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
unspecified
Other All
: Normal normal
: ---
Assigned To: Debarshi Ray
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-09 11:04 UTC by Carlos Soriano
Modified: 2014-04-29 12:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
display: Add edge thickness to labeler (996 bytes, patch)
2014-04-09 11:05 UTC, Carlos Soriano 		none Details | Review
display: Add edge thickness to labeler (1003 bytes, patch)
2014-04-09 12:11 UTC, Carlos Soriano 		committed Details | Review

Description Carlos Soriano 2014-04-09 11:04:58 UTC 
Sorry, it was itching me, see next comment for screenshots
Comment 1 Carlos Soriano 2014-04-09 11:05:04 UTC 
Created attachment 273880 [details] [review]
display: Add edge thickness to labeler

The edge antialising in the label was bad apealing.
Simple adding one pixeel more to the thickness it
looks better.
Comment 2 Carlos Soriano 2014-04-09 11:09:14 UTC 
oh sorry, screenshots are not taking the label.

It's similar to:
https://bugzilla.gnome.org/show_bug.cgi?id=727336
Comment 3 Bastien Nocera 2014-04-09 11:12:15 UTC 
(In reply to comment #1)
> Created an attachment (id=273880) [details] [review]
> display: Add edge thickness to labeler
> 
> The edge antialising in the label was bad apealing.
"apealing" isn't english.

> Simple adding one pixeel more to the thickness it

pixel.

> looks better.

Screenshots would still be useful. Try using GIMP if the builtin screenshot doesn't work.
Comment 4 Carlos Soriano 2014-04-09 12:08:44 UTC 
(In reply to comment #3)
> (In reply to comment #1)
> > Created an attachment (id=273880) [details] [review] [details] [review]
> > display: Add edge thickness to labeler
> > 
> > The edge antialising in the label was bad apealing.
> "apealing" isn't english.
> 
> > Simple adding one pixeel more to the thickness it
> 
> pixel.
> 
> > looks better.
> 
> Screenshots would still be useful. Try using GIMP if the builtin screenshot
> doesn't work.

Oh, didn't know  that.
http://i.imgur.com/iLMPJKF.png
Comment 5 Carlos Soriano 2014-04-09 12:11:09 UTC 
Created attachment 273884 [details] [review]
display: Add edge thickness to labeler

The edge antialising in the label was bad due to the
small thickness.
Adding one pixel more to the thickness
looks better.
Comment 6 Bastien Nocera 2014-04-09 15:29:43 UTC 
Jakub had comments about the corners not looking exactly right though.
Comment 7 Carlos Soriano 2014-04-10 11:16:26 UTC 
Seems the grid was already pixel aligned, I guess that because the problem is a curve, I can't pixel align a curve
I already pixel aligned each point of the path, even the curve controllers
but there's no change (I tried both pixel-aligning curve controllers or not with all the remaining points pixel-aligned)

There's something I'm overkilling?

On the other hand, Jakub said "ok" to the patch I posted adding thickness.
Comment 8 Jakub Steiner 2014-04-10 11:18:41 UTC 
The rounded corners do look thinner but even so look better than the ones on the thin variant. It's definitely an improvement from my POV.
Comment 9 Bastien Nocera 2014-04-10 11:51:39 UTC 
Review of attachment 273884 [details] [review]:

Looks good to commit after we've branched.
Comment 10 Bastien Nocera 2014-04-29 12:33:06 UTC 
Attachment 273884 [details] pushed as 61453b1 - display: Add edge thickness to labeler